feat: makefile project engineering design and build design by cubxxw · Pull Request #2161 · sealerio/sealer

cubxxw · 2023-04-01T03:10:25Z

Signed-off-by: Xinwei Xiong(cubxxw) 3293172751nss@gmail.com

Describe what this PR does / why we need it

Does this pull request fix one issue?

Fixes #2148

Describe how you did it

Describe how to verify it

Special notes for reviews

codecov-commenter · 2023-04-03T03:40:59Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 8.77%. Comparing base (150c4cb) to head (d093afc).
⚠️ Report is 21 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (150c4cb) and HEAD (d093afc). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (150c4cb) HEAD (d093afc)

unit-tests 1 0

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #2161       +/-   ##
==========================================
- Coverage   19.93%   8.77%   -11.17%     
==========================================
  Files          98     165       +67     
  Lines        9220   13805     +4585     
==========================================
- Hits         1838    1211      -627     
- Misses       7128   12438     +5310     
+ Partials      254     156       -98

Flag	Coverage Δ
e2e-tests	`8.77% <ø> (?)`
unit-tests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mouuii · 2023-04-04T01:38:07Z

rebase to serval commits

starnop · 2023-04-28T08:32:46Z

@cubxxw Cloud you please add more description for this PR?

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

makefile:What is needed to preserve it save makefile add makefile go.build as dirty Add the images and copyright portions of the makefile Clear the output directory to tools.clean add help info for samll makefile Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com> The help information is built End help, Color and case Complete the makefile tools section Finish implementing the code generator Initialize Initialize the contributor file Remove some irrelevant directories Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com> fix: part about build issues Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com> fix: part about build issues Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

… of the script Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

cubxxw · 2023-05-06T15:07:10Z

After completing the basic tests, I will create a design document in the form of Google Docs and sync it to an issue.

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

cubxxw · 2023-05-07T13:38:13Z

description of design: https://nsddd.notion.site/sealer-construction-engineering-design-e98b303493d5492e98aff79afadc1cce

kakaZhou719 · 2023-05-12T05:51:35Z

scripts/make-rules/tools.mk

+# sealer build use BUILD_TOOLS
+BUILD_TOOLS ?= golangci-lint goimports addlicense deepcopy-gen conversion-gen ginkgo go-junit-report
+# Code analysis tools
+ANALYSIS_TOOLS = golangci-lint goimports golines go-callvis kube-score


do we need all those tools ?

kakaZhou719 · 2023-05-12T05:52:48Z

scripts/make-rules/image.mk

+# docker registry: registry.example.com/namespace/image:tag as: registry.hub.docker.com/cubxxw/<image-name>:<tag>
+#
+
+DOCKER := docker


what does this image.mk do? do we need it ?

kakaZhou719 · 2023-05-12T05:54:29Z

cmd/sealer/cmd/version.go

+	}
+	//TODO!
+	// missinfo := []string{}
+	// if OutputInfo.KubernetesVersion == nil {


version just show sealer git info. no need to include cluster info. or we can support it later by using another cmd.

kakaZhou719 · 2023-05-12T05:55:18Z

cmd/sealer/cmd/version.go

 	return versionCmd
 }
+
+func PrintInfo() error {


could we split those code optimization from this pr

cubxxw closed this Apr 1, 2023

cubxxw reopened this Apr 3, 2023

github-actions bot added the ImageBuilding related to all staff with image building label Apr 3, 2023

cubxxw force-pushed the feature/makefile-super branch from 209813e to 0736b65 Compare April 4, 2023 14:12

github-actions bot added the Clusterfile label Apr 27, 2023

cubxxw added 9 commits May 6, 2023 19:38

Design pre-version storage

85f958d

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

save makefile

5f1da75

styles: Reformat part

9de0087

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

fix: Partial optimization

baa95a1

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

fix: Optimize the root makefile object

2edc235

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

feat(build): add options to the build script and optimize the details…

1b23e59

… of the script Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

feat: implement multiple solutions for building

d0ef7e1

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

cubxxw force-pushed the feature/makefile-super branch from aea8446 to d0ef7e1 Compare May 6, 2023 15:00

cubxxw changed the title ~~【draft】Design pre-version storage~~ feat: makefile project engineering design and build design May 6, 2023

cubxxw marked this pull request as ready for review May 6, 2023 15:05

cubxxw added 3 commits May 7, 2023 15:50

fix: partial makefile fixes issues

77288d1

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

feat: more friendly output from sealer version is supported

7c08696

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

feat: release

d093afc

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

kakaZhou719 reviewed May 12, 2023

View reviewed changes

cmd/sealer/cmd/version.go

return versionCmd

}

func PrintInfo() error {

Copy link

Member

kakaZhou719 May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we split those code optimization from this pr

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: makefile project engineering design and build design#2161

feat: makefile project engineering design and build design#2161
cubxxw wants to merge 12 commits intosealerio:mainfrom
cubxxw:feature/makefile-super

cubxxw commented Apr 1, 2023

Uh oh!

codecov-commenter commented Apr 3, 2023 •

edited

Loading

Uh oh!

mouuii commented Apr 4, 2023

Uh oh!

starnop commented Apr 28, 2023

Uh oh!

cubxxw commented May 6, 2023 •

edited

Loading

Uh oh!

cubxxw commented May 7, 2023 •

edited

Loading

Uh oh!

kakaZhou719 May 12, 2023

Uh oh!

kakaZhou719 May 12, 2023

Uh oh!

kakaZhou719 May 12, 2023

Uh oh!

kakaZhou719 May 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

cubxxw commented Apr 1, 2023

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

Uh oh!

codecov-commenter commented Apr 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mouuii commented Apr 4, 2023

Uh oh!

starnop commented Apr 28, 2023

Uh oh!

cubxxw commented May 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubxxw commented May 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kakaZhou719 May 12, 2023

Choose a reason for hiding this comment

Uh oh!

kakaZhou719 May 12, 2023

Choose a reason for hiding this comment

Uh oh!

kakaZhou719 May 12, 2023

Choose a reason for hiding this comment

Uh oh!

kakaZhou719 May 12, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented Apr 3, 2023 •

edited

Loading

cubxxw commented May 6, 2023 •

edited

Loading

cubxxw commented May 7, 2023 •

edited

Loading