Skip to content

Throw if resource's route path is not defined#150

Merged
andrii-balitskyi merged 13 commits intomainfrom
require-route-path
Feb 7, 2025
Merged

Throw if resource's route path is not defined#150
andrii-balitskyi merged 13 commits intomainfrom
require-route-path

Conversation

@andrii-balitskyi
Copy link
Contributor

@andrii-balitskyi andrii-balitskyi commented Jan 15, 2025

No description provided.

@vercel
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blueprint ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 1:56pm

@andrii-balitskyi andrii-balitskyi marked this pull request as ready for review January 17, 2025 13:53
@andrii-balitskyi andrii-balitskyi requested a review from a team as a code owner January 17, 2025 13:53
@andrii-balitskyi
Copy link
Contributor Author

andrii-balitskyi commented Feb 5, 2025

@razor-x Some of the updates I've made:

  • Updated the types, so the health_service is now removed and all tests are passing
  • Modified the action attempts logic to only pass valid AA types from the OpenAPI schema to the context, instead of the entire ActionAttempt[] array

Could you review commit 8e2738d? Note: The diff shows commented code because I had to temporarily comment it during the merge with main. It needed fixing, and I wanted to avoid rewriting the logic in the merge commit.

@andrii-balitskyi andrii-balitskyi merged commit f0dbd17 into main Feb 7, 2025
21 checks passed
@andrii-balitskyi andrii-balitskyi deleted the require-route-path branch February 7, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants