Add endpoint.response.actionAttemptType#153
Merged
andrii-balitskyi merged 7 commits intomainfrom Feb 4, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andrii-balitskyi
changed the title
endpoint.actionAttemptTypeendpoint.response.actionAttemptType
razor-x
approved these changes
Jan 27, 2025
Member
|
We need some way to validate this: if an endpoint returns an action attempt but does not set the type we can throw a helpful error. |
Contributor
Author
razor-x
reviewed
Jan 28, 2025
| responseKey === 'action_attempt' && | ||
| !isPathExcluded | ||
| ) { | ||
| throw new Error(`Missing action_attempt_type for path ${path}`) |
Member
There was a problem hiding this comment.
Can we also validate the action attempt type is a valid one?
razor-x
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148