Skip to content

Remove default_climate_setting #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
razor-x merged 1 commit into from
Nov 16, 2024
Merged

Remove default_climate_setting #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .storybook/seed-fake.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,15 +390,6 @@ export const seedFake = (db) => {
temperature_fahrenheit: 70,
current_climate_setting: {
hvac_mode_setting: 'heat_cool',
manual_override_allowed: false,
cooling_set_point_fahrenheit: 75,
cooling_set_point_celsius: 23.8,
heating_set_point_fahrenheit: 65,
heating_set_point_celsius: 18.3,
},
default_climate_setting: {
hvac_mode_setting: 'heat_cool',
manual_override_allowed: false,
cooling_set_point_fahrenheit: 75,
cooling_set_point_celsius: 23.8,
heating_set_point_fahrenheit: 65,
Expand All @@ -417,7 +408,6 @@ export const seedFake = (db) => {
min_cooling_set_point_celsius: 18.333333333333336,
min_heating_set_point_celsius: 7.222222222222222,
min_heating_cooling_delta_celsius: 2.7777777777777777,
is_temporary_manual_override_active: false,
name: 'Apartment 21A',
image_url:
'https://connect.getseam.com/assets/images/devices/ecobee_3-lite_front.png',
Expand Down Expand Up @@ -452,7 +442,6 @@ export const seedFake = (db) => {
temperature_fahrenheit: 70,
current_climate_setting: {
hvac_mode_setting: 'heat',
manual_override_allowed: false,
heating_set_point_celsius: 20,
heating_set_point_fahrenheit: 68,
},
Expand All @@ -469,7 +458,6 @@ export const seedFake = (db) => {
min_cooling_set_point_fahrenheit: 65,
max_heating_set_point_fahrenheit: 79,
min_heating_set_point_fahrenheit: 45,
is_temporary_manual_override_active: false,
name: 'debating book',
image_url:
'https://connect.getseam.com/assets/images/devices/ecobee_3-lite_front.png',
Expand Down
4 changes: 0 additions & 4 deletions src/lib/seam/components/DeviceDetails/ThermostatDeviceDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,13 +307,9 @@ const t = {
defaultSettings: 'Default settings',
defaultSettingsTooltip:
'When a scheduled climate reaches its end time, the default settings will kick in.',
defaultClimate: 'Default climate',
allowManualOverride: 'Allow manual override',
none: 'None',
fanModeSuccess: 'Successfully updated fan mode!',
fanModeError: 'Error updating fan mode. Please try again.',
manualOverrideSuccess: 'Successfully updated manual override!',
manualOverrideError: 'Error updating manual override. Please try again.',
climateSettingError: 'Error updating climate setting. Please try again.',
saved: 'Saved',
}
1 change: 0 additions & 1 deletion src/lib/seam/thermostats/thermostat-device.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ export interface ClimateSetting {
heating_set_point_celsius?: number
cooling_set_point_fahrenheit?: number
heating_set_point_fahrenheit?: number
manual_override_allowed?: boolean
}

export const isThermostatDevice = (
Expand Down
14 changes: 0 additions & 14 deletions src/lib/ui/thermostat/ClimateSettingStatus.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export const Content: Story = {
hvac_mode_setting: 'cool',
cooling_set_point_fahrenheit: 70,
cooling_set_point_celsius: 21,
manual_override_allowed: true,
}}
/>

Expand All @@ -29,7 +28,6 @@ export const Content: Story = {
hvac_mode_setting: 'cool',
cooling_set_point_fahrenheit: 70,
cooling_set_point_celsius: 21,
manual_override_allowed: true,
}}
iconPlacement='right'
/>
Expand All @@ -39,7 +37,6 @@ export const Content: Story = {
hvac_mode_setting: 'cool',
cooling_set_point_fahrenheit: 70,
cooling_set_point_celsius: 21,
manual_override_allowed: true,
}}
temperatureUnit='celsius'
/>
Expand All @@ -49,7 +46,6 @@ export const Content: Story = {
hvac_mode_setting: 'cool',
cooling_set_point_fahrenheit: 70,
cooling_set_point_celsius: 21,
manual_override_allowed: true,
}}
iconPlacement='right'
temperatureUnit='celsius'
Expand All @@ -60,15 +56,13 @@ export const Content: Story = {
hvac_mode_setting: 'heat',
heating_set_point_fahrenheit: 70,
heating_set_point_celsius: 21,
manual_override_allowed: true,
}}
/>
<ClimateSettingStatus
climateSetting={{
hvac_mode_setting: 'heat',
heating_set_point_fahrenheit: 70,
heating_set_point_celsius: 21,
manual_override_allowed: true,
}}
iconPlacement='right'
/>
Expand All @@ -78,7 +72,6 @@ export const Content: Story = {
hvac_mode_setting: 'heat',
heating_set_point_fahrenheit: 70,
heating_set_point_celsius: 21,
manual_override_allowed: true,
}}
temperatureUnit='celsius'
/>
Expand All @@ -87,7 +80,6 @@ export const Content: Story = {
hvac_mode_setting: 'heat',
heating_set_point_fahrenheit: 70,
heating_set_point_celsius: 21,
manual_override_allowed: true,
}}
iconPlacement='right'
temperatureUnit='celsius'
Expand All @@ -100,7 +92,6 @@ export const Content: Story = {
cooling_set_point_celsius: 21,
heating_set_point_fahrenheit: 60,
heating_set_point_celsius: 15,
manual_override_allowed: true,
}}
/>

Expand All @@ -111,7 +102,6 @@ export const Content: Story = {
cooling_set_point_celsius: 21,
heating_set_point_fahrenheit: 60,
heating_set_point_celsius: 15,
manual_override_allowed: true,
}}
iconPlacement='right'
/>
Expand All @@ -123,7 +113,6 @@ export const Content: Story = {
cooling_set_point_celsius: 21,
heating_set_point_fahrenheit: 60,
heating_set_point_celsius: 15,
manual_override_allowed: true,
}}
temperatureUnit='celsius'
/>
Expand All @@ -135,7 +124,6 @@ export const Content: Story = {
cooling_set_point_celsius: 21,
heating_set_point_fahrenheit: 60,
heating_set_point_celsius: 15,
manual_override_allowed: true,
}}
iconPlacement='right'
temperatureUnit='celsius'
Expand All @@ -144,14 +132,12 @@ export const Content: Story = {
<ClimateSettingStatus
climateSetting={{
hvac_mode_setting: 'off',
manual_override_allowed: false,
}}
/>

<ClimateSettingStatus
climateSetting={{
hvac_mode_setting: 'off',
manual_override_allowed: false,
}}
iconPlacement='right'
/>
Expand Down
Loading