feat: Improve icon scaling by using viewBox and fontSize
#671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razor-x
reviewed
Jan 22, 2025
razor-x
approved these changes
Jan 22, 2025
Member
razor-x
left a comment
razor-x
left a comment
There was a problem hiding this comment.
Neat. Just need to get CI green and should be good to merge. Please update the PR title if this fixes or improves something, e.g., feat: Improve icon scaling for ....
kadiryazici
changed the title
ViewBox for Icons.viewBox and fontSize
razor-x
approved these changes
Jan 22, 2025
Member
razor-x
left a comment
razor-x
left a comment
There was a problem hiding this comment.
@kadiryazici I undid some whitespace changes to trigger another deploy to get CI passing. I added you to vercel so future PR commits should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without viewbox even if we resize SVG's their path's wouldn't resize. With this PR svgs are scaling according to
font-size.scale: Xproperties are deleted due tofont-size