Skip to content

Conversation

@razor-x
Copy link
Member

@razor-x razor-x commented Feb 28, 2025

  • feat: Serialize null
  • feat: Do not serialize the empty string

@razor-x razor-x requested a review from phpnode February 28, 2025 00:17
@razor-x
Copy link
Member Author

razor-x commented Feb 28, 2025

@phpnode How does this look? Based on your suggestion on serializing null.

@stale stale bot added the stale label Mar 4, 2025
@seamapi seamapi deleted a comment from stale bot Mar 4, 2025
@razor-x razor-x removed the stale label Mar 4, 2025
@razor-x
Copy link
Member Author

razor-x commented Mar 5, 2025

Thanks @phpnode! Because this is a breaking change, I'm going to hold off merging it until work on the parser is further along. Just in case we discover something we didn't think of while trying to implement the parser that would need to be included in v2.

There is no real rush on this at the moment since without the parser we can't really use this effectively yet.

@stale stale bot added the stale label Mar 8, 2025
@stale stale bot closed this Mar 10, 2025
@seamapi seamapi deleted a comment from stale bot Mar 10, 2025
@razor-x razor-x reopened this Mar 10, 2025
razor-x added 2 commits March 24, 2025 19:43
BREAKING CHANGE: The primitive value null will now be serialized instead
of removed, e.g., { foo: null } will now be serialized to 'foo='.
BREAKING CHANGE: Any attempts to serialize the empty string
will now throw an UnserializableParamError.
@razor-x razor-x changed the base branch from main to beta March 25, 2025 02:44
razor-x added 4 commits March 24, 2025 19:45
BREAKING CHANGE: Any attempt to serialize an object
with a dot in the key will now throw an UnserializableParamError.
@razor-x razor-x merged commit 6f2b462 into beta Mar 28, 2025
13 checks passed
@razor-x razor-x deleted the serialize-null branch March 28, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants