Skip to content

Remove unsafe error filtering in E2E detail page tests#240

Closed
Copilot wants to merge 2 commits intoclaude/pull-and-continue-I9Lk9from
copilot/sub-pr-238
Closed

Remove unsafe error filtering in E2E detail page tests#240
Copilot wants to merge 2 commits intoclaude/pull-and-continue-I9Lk9from
copilot/sub-pr-238

Conversation

Copy link

Copilot AI commented Feb 10, 2026

The E2E tests for entity detail pages filtered page errors using a broad substring match that could hide legitimate runtime exceptions.

Changes

  • 7 test files updated: ability, item, location, move, nature, trainer, type detail specs
  • Error assertion pattern: Removed errors.filter((e) => !e.includes('Warning')) filter, replaced with direct expect(errors).toHaveLength(0) assertion

Before/After

// Before: Could hide errors like "Warning: User data corrupted"
expect(errors.filter((e) => !e.includes('Warning'))).toHaveLength(0);

// After: Asserts no errors occurred
expect(errors).toHaveLength(0);

If specific error messages need to be excluded, they should be filtered by exact match (see pokemon-detail.spec.ts for reference pattern).


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Replace broad "Warning" substring filter with direct assertion that
there are no page errors. The previous pattern could hide real runtime
exceptions that happened to include "Warning" in their message.

Changed in 7 files:
- e2e/ability-detail.spec.ts
- e2e/item-detail.spec.ts
- e2e/location-detail.spec.ts
- e2e/move-detail.spec.ts
- e2e/nature-detail.spec.ts
- e2e/trainer-detail.spec.ts
- e2e/type-detail.spec.ts

Addresses feedback: #238 (comment)

Co-authored-by: seandonn-boston <38230468+seandonn-boston@users.noreply.github.com>
Copy link
Author

Copilot AI commented Feb 10, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkpoint.prisma.io
    • Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node /home/REDACTED/work/PkdxPlusPlus/PkdxPlusPlus/node_modules/prisma/build/child {&#34;product&#34;:&#34;prisma&#34;,&#34;version&#34;:&#34;7.3.0&#34;,&#34;cli_install_type&#34;:&#34;local&#34;,&#34;information&#34;:&#34;&#34;,&#34;local_timestamp&#34;:&#34;2026-02-10T04:07:00Z&#34;,&#34;project_hash&#34;:&#34;3cfc3272&#34;,&#34;cli_path&#34;:&#34;/home/REDACTED/work/PkdxPlusPlus/PkdxPlusPlus/node_modules/.bin/prisma&#34;,&#34;cli_path_hash&#34;:&#34;6e3b49e (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update E2E tests for entity detail pages based on feedback Remove unsafe error filtering in E2E detail page tests Feb 10, 2026
@seandonn-boston seandonn-boston marked this pull request as ready for review February 17, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants