Skip to content

Remove unsafe error filtering in E2E detail page tests #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Remove unsafe error filtering in E2E detail page tests #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab9dafb
Initial plan
Copilot Feb 10, 2026
24e9dc4
fix: remove unsafe error filtering in E2E detail tests
Copilot Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/ability-detail.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ test.describe('Ability Detail Page', () => {

await expect(page.locator('text=Something went wrong')).not.toBeVisible();
await expect(page.locator('text=overgrow').first()).toBeVisible();
expect(errors.filter((e) => !e.includes('Warning'))).toHaveLength(0);
expect(errors).toHaveLength(0);
});

test('should display ability description', async ({ page }) => {
Expand Down
2 changes: 1 addition & 1 deletion e2e/item-detail.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ test.describe('Item Detail Page', () => {

await expect(page.locator('text=Something went wrong')).not.toBeVisible();
await expect(page.locator('text=potion').first()).toBeVisible();
expect(errors.filter((e) => !e.includes('Warning'))).toHaveLength(0);
expect(errors).toHaveLength(0);
});

test('should display item category', async ({ page }) => {
Expand Down
2 changes: 1 addition & 1 deletion e2e/location-detail.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ test.describe('Location Detail Page', () => {

await expect(page.locator('text=Something went wrong')).not.toBeVisible();
await expect(page.locator('text=pallet town').first()).toBeVisible();
expect(errors.filter((e) => !e.includes('Warning'))).toHaveLength(0);
expect(errors).toHaveLength(0);
});

test('should display region information', async ({ page }) => {
Expand Down
2 changes: 1 addition & 1 deletion e2e/move-detail.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ test.describe('Move Detail Page', () => {

await expect(page.locator('text=Something went wrong')).not.toBeVisible();
await expect(page.locator('text=tackle').first()).toBeVisible();
expect(errors.filter((e) => !e.includes('Warning'))).toHaveLength(0);
expect(errors).toHaveLength(0);
});

test('should display move type badge', async ({ page }) => {
Expand Down
2 changes: 1 addition & 1 deletion e2e/nature-detail.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ test.describe('Nature Detail Page', () => {

await expect(page.locator('text=Something went wrong')).not.toBeVisible();
await expect(page.locator('text=adamant').first()).toBeVisible();
expect(errors.filter((e) => !e.includes('Warning'))).toHaveLength(0);
expect(errors).toHaveLength(0);
});

test('should display stat changes', async ({ page }) => {
Expand Down
2 changes: 1 addition & 1 deletion e2e/trainer-detail.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ test.describe('Trainer Detail Page', () => {

await expect(page.locator('text=Something went wrong')).not.toBeVisible();
await expect(page.locator('text=Brock').first()).toBeVisible();
expect(errors.filter((e) => !e.includes('Warning'))).toHaveLength(0);
expect(errors).toHaveLength(0);
});

test('should display trainer title', async ({ page }) => {
Expand Down
2 changes: 1 addition & 1 deletion e2e/type-detail.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ test.describe('Type Detail Page', () => {

await expect(page.locator('text=Something went wrong')).not.toBeVisible();
await expect(page.locator('text=fire').first()).toBeVisible();
expect(errors.filter((e) => !e.includes('Warning'))).toHaveLength(0);
expect(errors).toHaveLength(0);
});

test('should display type matchups', async ({ page }) => {
Expand Down