test: raise coverage thresholds and add missing query tests#295
Open
seandonn-boston wants to merge 6 commits intomainfrom
Open
test: raise coverage thresholds and add missing query tests#295seandonn-boston wants to merge 6 commits intomainfrom
seandonn-boston wants to merge 6 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Raise functions/lines/statements thresholds from 80% to 85%. Add tests for getNatureList, searchNatures, getItemsByEvolution, and ability sortByCount branches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raises test coverage thresholds from 80% to 85% for functions, lines, and statements. Adds missing tests for uncovered query branches (getNatureList, searchNatures, getItemsByEvolution, ability sortByCount).
Branch coverage remains at 80% threshold — the project's current branch coverage is 80.6%, which doesn't provide enough margin for 85%. Raising branch coverage to 85% would require extensive test additions across complex UI components (ChartWrappers, ConstellationCanvas, SearchCommand) and is tracked as future work.
Changes
getNatureListandsearchNatures(covering search, sort, pagination branches)getItemsByEvolution(covering empty results, null filtering)sortByCountbranch (ascending + descending)Testing
Impact
Task Reference
Saga task: 2.15.74 — Increase branch coverage buffer from 81% to ~85% (partial — branches remain at 80%)
Automated by pkdx++ autoloop — session
eD2yLcycle 3