Merge pull request rails#51146 from rails/rm-deprecations-2

Remove all deprecated code from Active Record

Author: rafaelfranca

activerecord/CHANGELOG.md

@@ -1,3 +1,130 @@
+*   Remove deprecated behavior that would rollback a transaction block when exited using `return`, `break` or `throw`.
+
+    *Rafael Mendonça França*
+
+*   Deprecate `Rails.application.config.active_record.commit_transaction_on_non_local_return`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated support to pass `rewhere` to `ActiveRecord::Relation#merge`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated support to pass `deferrable: true` to `add_foreign_key`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated support to quote `ActiveSupport::Duration`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `#quote_bound_value`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `ActiveRecord::ConnectionAdapters::ConnectionPool#connection_klass`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated support to apply `#connection_pool_list`, `#active_connections?`, `#clear_active_connections!`,
+    `#clear_reloadable_connections!`, `#clear_all_connections!` and `#flush_idle_connections!` to the connections pools
+    for the current role when the `role` argument isn't provided.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `#all_connection_pools`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `ActiveRecord::ConnectionAdapters::SchemaCache#data_sources`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `ActiveRecord::ConnectionAdapters::SchemaCache.load_from`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `#all_foreign_keys_valid?` from database adapters.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated support to passing coder and class as second argument to `serialize`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated support to `ActiveRecord::Base#read_attribute(:id)` to return the custom primary key value.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `TestFixtures.fixture_path`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated behavior to support referring to a singular association by its plural name.
+
+    *Rafael Mendonça França*
+
+*   Deprecate `Rails.application.config.active_record.allow_deprecated_singular_associations_name`
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated support to passing `SchemaMigration` and `InternalMetadata` classes as arguments to
+    `ActiveRecord::MigrationContext`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `ActiveRecord::Migration.check_pending` method.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `ActiveRecord::LogSubscriber.runtime` method.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `ActiveRecord::LogSubscriber.runtime=` method.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `ActiveRecord::LogSubscriber.reset_runtime` method.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated support to define `explain` in the connection adapter with 2 arguments.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `ActiveRecord::ActiveJobRequiredError`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `ActiveRecord::Base.clear_active_connections!`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `ActiveRecord::Base.clear_reloadable_connections!`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `ActiveRecord::Base.clear_all_connections!`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `ActiveRecord::Base.flush_idle_connections!`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `name` argument from `ActiveRecord::Base.remove_connection`.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated support to call `alias_attribute` with non-existent attribute names.
+
+    *Rafael Mendonça França*
+
+*   Remove deprecated `Rails.application.config.active_record.suppress_multiple_database_warning`.
+
+    *Rafael Mendonça França*
+
 *   Add ActiveRecord::Encryption::MessagePackMessageSerializer
 
     Serialize data to the MessagePack format, for efficient storage in binary columns.

activerecord/lib/active_record.rb

@@ -333,8 +333,19 @@ def self.global_executor_concurrency # :nodoc:
   singleton_class.attr_accessor :run_after_transaction_callbacks_in_order_defined
   self.run_after_transaction_callbacks_in_order_defined = false
 
-  singleton_class.attr_accessor :commit_transaction_on_non_local_return
-  self.commit_transaction_on_non_local_return = false
+  def self.commit_transaction_on_non_local_return
+    ActiveRecord.deprecator.warn <<-WARNING.squish
+      `Rails.application.config.active_record.commit_transaction_on_non_local_return`
+      is deprecated and will be removed in Rails 7.3.
+    WARNING
+  end
+
+  def self.commit_transaction_on_non_local_return=(value)
+    ActiveRecord.deprecator.warn <<-WARNING.squish
+      `Rails.application.config.active_record.commit_transaction_on_non_local_return`
+      is deprecated and will be removed in Rails 7.3.
+    WARNING
+  end
 
   ##
   # :singleton-method: warn_on_records_fetched_greater_than
@@ -413,20 +424,6 @@ def self.global_executor_concurrency # :nodoc:
   singleton_class.attr_accessor :dump_schemas
   self.dump_schemas = :schema_search_path
 
-  def self.suppress_multiple_database_warning
-    ActiveRecord.deprecator.warn(<<-MSG.squish)
-      config.active_record.suppress_multiple_database_warning is deprecated and will be removed in Rails 7.2.
-      It no longer has any effect and should be removed from the configuration file.
-    MSG
-  end
-
-  def self.suppress_multiple_database_warning=(value)
-    ActiveRecord.deprecator.warn(<<-MSG.squish)
-      config.active_record.suppress_multiple_database_warning= is deprecated and will be removed in Rails 7.2.
-      It no longer has any effect and should be removed from the configuration file.
-    MSG
-  end
-
   ##
   # :singleton-method: verify_foreign_keys_for_fixtures
   # If true, Rails will verify all foreign keys in the database after loading fixtures.
@@ -436,12 +433,19 @@ def self.suppress_multiple_database_warning=(value)
   singleton_class.attr_accessor :verify_foreign_keys_for_fixtures
   self.verify_foreign_keys_for_fixtures = false
 
-  ##
-  # :singleton-method: allow_deprecated_singular_associations_name
-  # If true, Rails will continue allowing plural association names in where clauses on singular associations
-  # This behavior will be removed in Rails 7.2.
-  singleton_class.attr_accessor :allow_deprecated_singular_associations_name
-  self.allow_deprecated_singular_associations_name = true
+  def self.allow_deprecated_singular_associations_name
+    ActiveRecord.deprecator.warn <<-WARNING.squish
+      `Rails.application.config.active_record.allow_deprecated_singular_associations_name`
+      is deprecated and will be removed in Rails 7.3.
+    WARNING
+  end
+
+  def self.allow_deprecated_singular_associations_name=(value)
+    ActiveRecord.deprecator.warn <<-WARNING.squish
+      `Rails.application.config.active_record.allow_deprecated_singular_associations_name`
+      is deprecated and will be removed in Rails 7.3.
+    WARNING
+  end
 
   singleton_class.attr_accessor :query_transformers
   self.query_transformers = []

activerecord/lib/active_record/attribute_methods.rb

@@ -78,38 +78,15 @@ def eagerly_generate_alias_attribute_methods(_new_name, _old_name) # :nodoc:
       end
 
       def alias_attribute_method_definition(code_generator, pattern, new_name, old_name)
-        method_name = pattern.method_name(new_name).to_s
-        target_name = pattern.method_name(old_name).to_s
-        parameters = pattern.parameters
         old_name = old_name.to_s
 
-        method_defined = method_defined?(target_name) || private_method_defined?(target_name)
-        manually_defined = method_defined &&
-          !self.instance_method(target_name).owner.is_a?(GeneratedAttributeMethods)
-        reserved_method_name = ::ActiveRecord::AttributeMethods.dangerous_attribute_methods.include?(target_name)
-
         if !abstract_class? && !has_attribute?(old_name)
-          # We only need to issue this deprecation warning once, so we issue it when defining the original reader method.
-          should_warn = target_name == old_name
-          if should_warn
-            ActiveRecord.deprecator.warn(
-              "#{self} model aliases `#{old_name}`, but `#{old_name}` is not an attribute. " \
-              "Starting in Rails 7.2, alias_attribute with non-attribute targets will raise. " \
-              "Use `alias_method :#{new_name}, :#{old_name}` or define the method manually."
-            )
-          end
-          super
-        elsif manually_defined && !reserved_method_name
-          aliased_method_redefined_as_well = method_defined_within?(method_name, self)
-          return if aliased_method_redefined_as_well
-
-          ActiveRecord.deprecator.warn(
-            "#{self} model aliases `#{old_name}` and has a method called `#{target_name}` defined. " \
-            "Starting in Rails 7.2 `#{method_name}` will not be calling `#{target_name}` anymore. " \
-            "You may want to additionally define `#{method_name}` to preserve the current behavior."
-          )
-          super
+          raise ArgumentError, "#{self.name} model aliases `#{old_name}`, but `#{old_name}` is not an attribute. " \
+            "Use `alias_method :#{new_name}, :#{old_name}` or define the method manually."
         else
+          method_name = pattern.method_name(new_name).to_s
+          parameters = pattern.parameters
+
           define_proxy_call(code_generator, method_name, pattern.proxy_target, parameters, old_name,
             namespace: :proxy_alias_attribute
           )

activerecord/lib/active_record/attribute_methods/read.rb

@@ -30,19 +30,7 @@ def read_attribute(attr_name, &block)
         name = attr_name.to_s
         name = self.class.attribute_aliases[name] || name
 
-        return @attributes.fetch_value(name, &block) unless name == "id" && @primary_key
-
-        if self.class.composite_primary_key?
-          @attributes.fetch_value("id", &block)
-        else
-          if @primary_key != "id"
-            ActiveRecord.deprecator.warn(<<-MSG.squish)
-              Using read_attribute(:id) to read the primary key value is deprecated.
-              Use #id instead.
-            MSG
-          end
-          @attributes.fetch_value(@primary_key, &block)
-        end
+        @attributes.fetch_value(name, &block)
       end
 
       # This method exists to avoid the expensive primary_key check internally, without

activerecord/lib/active_record/attribute_methods/serialization.rb

@@ -180,29 +180,7 @@ module ClassMethods
         #     serialize :preferences, coder: Rot13JSON
         #   end
         #
-        def serialize(attr_name, class_name_or_coder = nil, coder: nil, type: Object, yaml: {}, **options)
-          unless class_name_or_coder.nil?
-            if class_name_or_coder == ::JSON || [:load, :dump].all? { |x| class_name_or_coder.respond_to?(x) }
-              ActiveRecord.deprecator.warn(<<~MSG)
-                Passing the coder as positional argument is deprecated and will be removed in Rails 7.2.
-
-                Please pass the coder as a keyword argument:
-
-                  serialize #{attr_name.inspect}, coder: #{class_name_or_coder}
-              MSG
-              coder = class_name_or_coder
-            else
-              ActiveRecord.deprecator.warn(<<~MSG)
-                Passing the class as positional argument is deprecated and will be removed in Rails 7.2.
-
-                Please pass the class as a keyword argument:
-
-                  serialize #{attr_name.inspect}, type: #{class_name_or_coder.name}
-              MSG
-              type = class_name_or_coder
-            end
-          end
-
+        def serialize(attr_name, coder: nil, type: Object, yaml: {}, **options)
           coder ||= default_column_serializer
           unless coder
             raise ArgumentError, <<~MSG.squish