Skip to content

Commit 5515fa4

Browse files
committed
Remove deprecated methods in ActiveRecord::Base
1 parent 7a08a86 commit 5515fa4

File tree

3 files changed

+25
-28
lines changed

3 files changed

+25
-28
lines changed

activerecord/CHANGELOG.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
* Remove deprecated `ActiveRecord::Base.clear_active_connections!`.
2+
3+
*Rafael Mendonça França*
4+
5+
* Remove deprecated `ActiveRecord::Base.clear_reloadable_connections!`.
6+
7+
*Rafael Mendonça França*
8+
9+
* Remove deprecated `ActiveRecord::Base.clear_all_connections!`.
10+
11+
*Rafael Mendonça França*
12+
13+
* Remove deprecated `ActiveRecord::Base.flush_idle_connections!`.
14+
15+
*Rafael Mendonça França*
16+
117
* Remove deprecated `name` argument from `ActiveRecord::Base.remove_connection`.
218

319
*Rafael Mendonça França*

activerecord/lib/active_record/connection_handling.rb

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -320,35 +320,7 @@ def clear_cache! # :nodoc:
320320
connection_pool.schema_cache.clear!
321321
end
322322

323-
def clear_active_connections!(role = nil)
324-
deprecation_for_delegation(__method__)
325-
connection_handler.clear_active_connections!(role)
326-
end
327-
328-
def clear_reloadable_connections!(role = nil)
329-
deprecation_for_delegation(__method__)
330-
connection_handler.clear_reloadable_connections!(role)
331-
end
332-
333-
def clear_all_connections!(role = nil)
334-
deprecation_for_delegation(__method__)
335-
connection_handler.clear_all_connections!(role)
336-
end
337-
338-
def flush_idle_connections!(role = nil)
339-
deprecation_for_delegation(__method__)
340-
connection_handler.flush_idle_connections!(role)
341-
end
342-
343323
private
344-
def deprecation_for_delegation(method)
345-
ActiveRecord.deprecator.warn(<<-MSG.squish)
346-
Calling `ActiveRecord::Base.#{method} is deprecated. Please
347-
call the method directly on the connection handler; for
348-
example: `ActiveRecord::Base.connection_handler.#{method}`.
349-
MSG
350-
end
351-
352324
def resolve_config_for_connection(config_or_env)
353325
raise "Anonymous class is not allowed." unless name
354326

guides/source/7_2_release_notes.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,15 @@ Please refer to the [Changelog][active-record] for detailed changes.
111111

112112
* Remove deprecated `name` argument from `ActiveRecord::Base.remove_connection`.
113113

114+
* Remove deprecated `ActiveRecord::Base.clear_active_connections!`.
115+
116+
* Remove deprecated `ActiveRecord::Base.clear_reloadable_connections!`.
117+
118+
* Remove deprecated `ActiveRecord::Base.clear_all_connections!`.
119+
120+
* Remove deprecated `ActiveRecord::Base.flush_idle_connections!`.
121+
122+
114123
### Deprecations
115124

116125
### Notable changes

0 commit comments

Comments
 (0)