Skip to content

Commit 9391f0a

Browse files
committed
Remove deprecated #all_foreign_keys_valid? from database adapters
1 parent 8069cc8 commit 9391f0a

File tree

4 files changed

+6
-15
lines changed

4 files changed

+6
-15
lines changed

activerecord/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
* Remove deprecated `#all_foreign_keys_valid?` from database adapters.
2+
3+
*Rafael Mendonça França*
4+
15
* Remove deprecated support to passing coder and class as second argument to `serialize`.
26

37
*Rafael Mendonça França*

activerecord/lib/active_record/connection_adapters/abstract_adapter.rb

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -647,15 +647,6 @@ def disable_referential_integrity
647647
yield
648648
end
649649

650-
# Override to check all foreign key constraints in a database.
651-
def all_foreign_keys_valid?
652-
check_all_foreign_keys_valid!
653-
true
654-
rescue ActiveRecord::StatementInvalid
655-
false
656-
end
657-
deprecate :all_foreign_keys_valid?, deprecator: ActiveRecord.deprecator
658-
659650
# Override to check all foreign key constraints in a database.
660651
# The adapter should raise a +ActiveRecord::StatementInvalid+ if foreign key
661652
# constraints are not met.

activerecord/test/cases/adapter_test.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -459,12 +459,6 @@ def test_truncate_tables_with_query_cache
459459
@connection.disable_query_cache!
460460
end
461461

462-
def test_all_foreign_keys_valid_is_deprecated
463-
assert_deprecated(ActiveRecord.deprecator) do
464-
@connection.all_foreign_keys_valid?
465-
end
466-
end
467-
468462
# test resetting sequences in odd tables in PostgreSQL
469463
if ActiveRecord::Base.connection.respond_to?(:reset_pk_sequence!)
470464
require "models/movie"

guides/source/7_2_release_notes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,8 @@ Please refer to the [Changelog][active-record] for detailed changes.
142142

143143
* Remove deprecated support to passing coder and class as second argument to `serialize`.
144144

145+
* Remove deprecated `#all_foreign_keys_valid?` from database adapters.
146+
145147
### Deprecations
146148

147149
* Deprecate `Rails.application.config.active_record.allow_deprecated_singular_associations_name`

0 commit comments

Comments
 (0)