Skip to content

Commit a30e3ba

Browse files
authored
Merge pull request rails#50668 from Earlopain/clean-mail-dependencies
Remove workaround for `mail` gem dependencies
2 parents fc75fed + 45f64f5 commit a30e3ba

File tree

4 files changed

+5
-18
lines changed

4 files changed

+5
-18
lines changed

Gemfile.lock

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,19 +32,13 @@ PATH
3232
activerecord (= 7.2.0.alpha)
3333
activestorage (= 7.2.0.alpha)
3434
activesupport (= 7.2.0.alpha)
35-
mail (>= 2.7.1)
36-
net-imap
37-
net-pop
38-
net-smtp
35+
mail (>= 2.8.0)
3936
actionmailer (7.2.0.alpha)
4037
actionpack (= 7.2.0.alpha)
4138
actionview (= 7.2.0.alpha)
4239
activejob (= 7.2.0.alpha)
4340
activesupport (= 7.2.0.alpha)
44-
mail (~> 2.5, >= 2.5.4)
45-
net-imap
46-
net-pop
47-
net-smtp
41+
mail (~> 2.5, >= 2.8.0)
4842
rails-dom-testing (~> 2.2)
4943
actionpack (7.2.0.alpha)
5044
actionview (= 7.2.0.alpha)

actionmailbox/actionmailbox.gemspec

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,5 @@ Gem::Specification.new do |s|
3838
s.add_dependency "activejob", version
3939
s.add_dependency "actionpack", version
4040

41-
s.add_dependency "mail", ">= 2.7.1"
42-
s.add_dependency "net-imap"
43-
s.add_dependency "net-pop"
44-
s.add_dependency "net-smtp"
41+
s.add_dependency "mail", ">= 2.8.0"
4542
end

actionmailer/actionmailer.gemspec

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@ Gem::Specification.new do |s|
3838
s.add_dependency "actionview", version
3939
s.add_dependency "activejob", version
4040

41-
s.add_dependency "mail", ["~> 2.5", ">= 2.5.4"]
42-
s.add_dependency "net-imap"
43-
s.add_dependency "net-pop"
44-
s.add_dependency "net-smtp"
41+
s.add_dependency "mail", ["~> 2.5", ">= 2.8.0"]
4542
s.add_dependency "rails-dom-testing", "~> 2.2"
4643
end

actionmailer/lib/action_mailer/delivery_methods.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ module DeliveryMethods
3232

3333
add_delivery_method :sendmail, Mail::Sendmail,
3434
location: "/usr/sbin/sendmail",
35-
# See breaking change in the mail gem - https://github.com/mikel/mail/commit/7e1196bd29815a0901d7290c82a332c0959b163a
36-
arguments: Gem::Version.new(Mail::VERSION.version) >= Gem::Version.new("2.8.0") ? %w[-i] : "-i"
35+
arguments: %w[-i]
3736

3837
add_delivery_method :test, Mail::TestMailer
3938
end

0 commit comments

Comments
 (0)