Remove deprecated support to pass deferrable: true to add_foreign_key

Author: rafaelfranca

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Remove deprecated support to pass `deferrable: true` to `add_foreign_key`.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated support to quote `ActiveSupport::Duration`.
 
     *Rafael Mendonça França*

activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb

@@ -522,14 +522,6 @@ def index_name(table_name, options) # :nodoc:
         end
 
         def add_foreign_key(from_table, to_table, **options)
-          if options[:deferrable] == true
-            ActiveRecord.deprecator.warn(<<~MSG)
-              `deferrable: true` is deprecated in favor of `deferrable: :immediate`, and will be removed in Rails 7.2.
-            MSG
-
-            options[:deferrable] = :immediate
-          end
-
           assert_valid_deferrable(options[:deferrable])
 
           super

activerecord/lib/active_record/connection_adapters/sqlite3/schema_statements.rb

@@ -53,14 +53,6 @@ def indexes(table_name)
         end
 
         def add_foreign_key(from_table, to_table, **options)
-          if options[:deferrable] == true
-            ActiveRecord.deprecator.warn(<<~MSG)
-              `deferrable: true` is deprecated in favor of `deferrable: :immediate`, and will be removed in Rails 7.2.
-            MSG
-
-            options[:deferrable] = :immediate
-          end
-
           assert_valid_deferrable(options[:deferrable])
 
           alter_table(from_table) do |definition|

activerecord/test/cases/migration/foreign_key_test.rb

@@ -589,18 +589,6 @@ def test_schema_dumping_with_defferable_initially_immediate
 
             assert_match %r{\s+add_foreign_key "astronauts", "rockets", deferrable: :immediate$}, output
           end
-
-          def test_deferrable_true_foreign_key
-            assert_deprecated(ActiveRecord.deprecator) do
-              @connection.add_foreign_key :astronauts, :rockets, column: "rocket_id", deferrable: true
-            end
-
-            foreign_keys = @connection.foreign_keys("astronauts")
-            assert_equal 1, foreign_keys.size
-
-            fk = foreign_keys.first
-            assert_equal :immediate, fk.deferrable
-          end
         end
 
         def test_does_not_create_foreign_keys_when_bypassed_by_config

guides/source/7_2_release_notes.md

@@ -160,6 +160,8 @@ Please refer to the [Changelog][active-record] for detailed changes.
 
 *   Remove deprecated support to quote `ActiveSupport::Duration`.
 
+*   Remove deprecated support to pass `deferrable: true` to `add_foreign_key`.
+
 ### Deprecations
 
 *   Deprecate `Rails.application.config.active_record.allow_deprecated_singular_associations_name`