add circular reference detection to prevent infinite loops#184
Open
ryo-rm wants to merge 1 commit intoseantomburke:masterfrom
Open
add circular reference detection to prevent infinite loops#184ryo-rm wants to merge 1 commit intoseantomburke:masterfrom
ryo-rm wants to merge 1 commit intoseantomburke:masterfrom
Conversation
- Only check for circular references on first attempt (retryIndex === 0) - Allow retries to proceed without circular reference interference - Maintain visitedUrls tracking only on first attempt - Add comprehensive circular reference test coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Some websites have sitemaps with circular references, which can cause infinite loops and prevent the crawler from completing.
Fix
Added circular reference detection by tracking visited URLs to prevent infinite loops.