feat: added the global timeout feature for the entire process#191
Open
Manav-Desai-07 wants to merge 2 commits intoseantomburke:masterfrom
Open
feat: added the global timeout feature for the entire process#191Manav-Desai-07 wants to merge 2 commits intoseantomburke:masterfrom
Manav-Desai-07 wants to merge 2 commits intoseantomburke:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a global timeout feature for Sitemapper. The new globalTimeout option allows developers to set a maximum overall execution time for sitemap parsing. This prevents the process from running indefinitely, especially when encountering irregular or malformed sitemaps.
Changes
Benefits: