Skip to content

Bump Go to 1.26 and use newer language features#85

Merged
colinodell merged 2 commits intomainfrom
go-1.26
Feb 25, 2026
Merged

Bump Go to 1.26 and use newer language features#85
colinodell merged 2 commits intomainfrom
go-1.26

Conversation

@colinodell
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request attempts to upgrade Go from version 1.25 to 1.26 and modernize the codebase by replacing the k8s.io/utils/ptr package with Go's built-in new() function and using the standard library maps.Copy() function. However, the PR contains critical bugs in the implementation of these changes.

Changes:

  • Update Go version to 1.26.0 across go.mod, go.work, api/go.mod, Dockerfile, and GitHub Actions
  • Replace ptr.To() calls with new() for creating pointers to primitive values
  • Replace manual map copying loops with maps.Copy() function

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
go.work Updates Go version directive to 1.26.0
go.mod Updates Go version directive to 1.26.0
api/go.mod Updates Go version directive to 1.26.0
Dockerfile Updates base image to golang:1.26.0-alpine3.23
.github/actions/setup-go/action.yml Updates default Go version to 1.26
internal/webhooks/buildkit_template.go Removes ptr import, attempts to replace ptr.To() with new()
internal/controllers/buildkit/builder_test.go Removes ptr import, attempts to replace ptr.To() with new()
internal/controllers/buildkit/builder.go Removes ptr import, attempts to replace ptr.To() with new()
internal/controllers/buildkit/resources/merge.go Adds maps import, replaces manual map copying with maps.Copy()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.22%. Comparing base (f32cfea) to head (f1db9cf).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/webhooks/buildkit_template.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   76.30%   76.22%   -0.09%     
==========================================
  Files          14       14              
  Lines         574      572       -2     
==========================================
- Hits          438      436       -2     
  Misses        117      117              
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinodell colinodell enabled auto-merge (squash) February 25, 2026 15:38
@colinodell colinodell merged commit 0119a86 into main Feb 25, 2026
6 checks passed
@colinodell colinodell deleted the go-1.26 branch February 25, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants