Add tables to column warning logs#91
Merged
AndrewCiambrone merged 6 commits intomasterfrom Apr 8, 2026
Merged
Conversation
ahartz1
commented
Apr 8, 2026
This reverts commit 9fe0306.
AndrewCiambrone
approved these changes
Apr 8, 2026
Collaborator
AndrewCiambrone
left a comment
AndrewCiambrone
left a comment
There was a problem hiding this comment.
Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are columns in the source table that are not in the destination, or vice versa, we log out the columns; however, we do not specify which tables they came from. This PR adds the source and destination tables to the logs (at the end, where they have less likelihood of interfering with existing monitors).
I have also added some things that were required to properly run the tests (to match the directions given in the
contributingdocument).PG_TEST_DATABASE_URLin.env.test.dockerMYSQLTEST_DATABASE_URLin.env.test.dockerPATHdefinition in the Dockerfile to additionally include/root/.pyenv/shimsdocker-compose.ymlfile to ensure the tests are invoked correctlyI also ran
blackon the files I touched (as noted in the contributing document). I had to revert the changes to thedruzhba/table.pyfile because it failed the linting check here in GitHub.