This repository was archived by the owner on Aug 26, 2024. It is now read-only.
process.dedupe() using sets instead of lists & dict.keys()#255
Open
UpwardTrajectory wants to merge 2 commits intoseatgeek:masterfrom
Open
process.dedupe() using sets instead of lists & dict.keys()#255UpwardTrajectory wants to merge 2 commits intoseatgeek:masterfrom
UpwardTrajectory wants to merge 2 commits intoseatgeek:masterfrom
Conversation
…stead of a list of dictionary keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe no one asked for this, but I saw a very minor improvement. (This is my first ever contribution attempt to a stranger's library, I'm open to critiques re: my process.)
This is slightly more readable and doesn't use
dict.keys()in order to getsetfunctionality. Previously,but now
type(deduped) = list