Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR I've added a script which generates XML VectorDrawables so we can use the GDS Central Icons in XML views as well.
Pull new icon assets from Green repository. Noticed that some assets, e.g., BrandSwishWord wasn't generated properly using the s2c script.
Due to quality issues using the s2c script I removed the usage of this entirely, and rely on the generated VectorDrawables as single source of truth. The ImageVectors for Compose are now just a wrapper around the XML Drawables instead.
Type of Change
Backward Compatibility
@Deprecatedannotation and migration guidance)If breaking changes or deprecations, please explain:
Changes Made
Screenshots / Videos
N/A
Testing
Test details:
Documentation
Checklist
./gradlew spotlessApply)Additional Notes