Skip to content

Update icon assets#74

Merged
enerothseb merged 6 commits intomainfrom
update-icon-assets
Mar 10, 2026
Merged

Update icon assets#74
enerothseb merged 6 commits intomainfrom
update-icon-assets

Conversation

@enerothseb
Copy link
Collaborator

@enerothseb enerothseb commented Mar 10, 2026

Description

In this PR I've added a script which generates XML VectorDrawables so we can use the GDS Central Icons in XML views as well.

Pull new icon assets from Green repository. Noticed that some assets, e.g., BrandSwishWord wasn't generated properly using the s2c script.

Due to quality issues using the s2c script I removed the usage of this entirely, and rely on the generated VectorDrawables as single source of truth. The ImageVectors for Compose are now just a wrapper around the XML Drawables instead.

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 Style/UI change (visual changes to components)
  • ♻️ Code refactoring (no functional changes)
  • ⚡ Performance improvement

Backward Compatibility

  • This change is backward compatible
  • This change includes deprecations (with @Deprecated annotation and migration guidance)
  • This change includes breaking changes (requires major version bump)

If breaking changes or deprecations, please explain:

Changes Made

  • Pull new Icon assets from Green
  • Add XML Drawables as source of truth
  • Replace ImageVector representation of icons, and wrap XML Drawable resources instead

Screenshots / Videos

Screenshot_20260310_081737

N/A

Testing

  • Tested in the companion app
  • Tested in light and dark themes
  • Tested with different screen sizes/orientations
  • Verified existing functionality still works

Test details:

Documentation

  • Updated KDoc comments with usage examples
  • Updated README if needed
  • Added preview composables for new components

Checklist

  • My code follows the project's code style (ran ./gradlew spotlessApply)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added usage examples for new public APIs
  • Any dependent changes have been merged and published

Additional Notes

Copy link
Contributor

@lisandra-santos lisandra-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@enerothseb enerothseb merged commit f46427b into main Mar 10, 2026
6 checks passed
@enerothseb enerothseb deleted the update-icon-assets branch March 10, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants