Use stricter comparison

Author: sebastianbergmann

src/Event/Value/ComparisonFailureBuilder.php

@@ -28,7 +28,7 @@ public static function from(Throwable $t): ?ComparisonFailure
             return null;
         }
 
-        if (!$t->getComparisonFailure()) {
+        if ($t->getComparisonFailure() === null) {
             return null;
         }
 

src/Framework/Constraint/Constraint.php

@@ -94,7 +94,7 @@ protected function fail(mixed $other, string $description, ?ComparisonFailure $c
 
         $additionalFailureDescription = $this->additionalFailureDescription($other);
 
-        if ($additionalFailureDescription) {
+        if ($additionalFailureDescription !== '') {
             $failureDescription .= "\n" . $additionalFailureDescription;
         }
 

src/Framework/Constraint/JsonMatches.php

@@ -59,7 +59,7 @@ protected function matches(mixed $other): bool
             return false;
         }
 
-        return $recodedOther == $recodedValue;
+        return $recodedOther === $recodedValue;
     }
 
     /**

src/Framework/MockObject/Runtime/Invocation.php

@@ -130,7 +130,7 @@ public function toString(): string
                     $this->parameters,
                 ),
             ),
-            $this->returnType ? sprintf(': %s', $this->returnType) : '',
+            $this->returnType !== '' ? sprintf(': %s', $this->returnType) : '',
         );
     }
 

src/Framework/MockObject/Runtime/Matcher.php

@@ -97,7 +97,7 @@ public function invoked(Invocation $invocation): mixed
                 ->__phpunit_getInvocationHandler()
                 ->lookupMatcher($this->afterMatchBuilderId);
 
-            if (!$matcher) {
+            if ($matcher === null) {
                 throw new MatchBuilderNotFoundException($this->afterMatchBuilderId);
             }
         }
@@ -118,7 +118,7 @@ public function invoked(Invocation $invocation): mixed
             );
         }
 
-        if ($this->stub) {
+        if ($this->stub !== null) {
             return $this->stub->invoke($invocation);
         }
 
@@ -138,7 +138,7 @@ public function matches(Invocation $invocation): bool
                 ->__phpunit_getInvocationHandler()
                 ->lookupMatcher($this->afterMatchBuilderId);
 
-            if (!$matcher) {
+            if ($matcher === null) {
                 throw new MatchBuilderNotFoundException($this->afterMatchBuilderId);
             }
 

src/Framework/TestCase.php

@@ -1354,7 +1354,7 @@ private function verifyMockObjects(): void
      */
     private function checkRequirements(): void
     {
-        if (!$this->methodName || !method_exists($this, $this->methodName)) {
+        if ($this->methodName === '' || !method_exists($this, $this->methodName)) {
             return;
         }
 
@@ -1770,7 +1770,7 @@ private function compareGlobalStateSnapshots(Snapshot $before, Snapshot $after):
      */
     private function compareGlobalStateSnapshotPart(array $before, array $after, string $header): void
     {
-        if ($before != $after) {
+        if ($before !== $after) {
             $differ = new Differ(new UnifiedDiffOutputBuilder($header));
 
             Event\Facade::emitter()->testConsideredRisky(

src/Runner/PHPT/PhptTestCase.php

@@ -224,7 +224,7 @@ public function run(): void
             } elseif ($e instanceof ExpectationFailedException) {
                 $comparisonFailure = $e->getComparisonFailure();
 
-                if ($comparisonFailure) {
+                if ($comparisonFailure !== null) {
                     $diff = $comparisonFailure->getDiff();
                 } else {
                     $diff = $e->getMessage();
@@ -238,7 +238,7 @@ public function run(): void
                     (string) $trace[0]['file'],
                     (int) $trace[0]['line'],
                     $trace,
-                    $comparisonFailure ? $diff : '',
+                    $comparisonFailure !== null ? $diff : '',
                 );
             }