-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Emit warning when OPCache is enabled while collecting coverage #6299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
27511be
to
ae7c73e
Compare
@sebastianbergmann any tips on how to run this test properly in the phar tests? locally it works for me, but CI errors |
Short answer: don't. I do not see anything here that would be specific to the PHAR. A regular PHPT test should be all that we need here. Does that help? |
we don't currently run regular tests with opcache + coverage-driver, therefore I cannot make the new test in CI fail. |
Prevents "Warning: JIT is incompatible with third party extensions that override zend_execute_ex(). JIT disabled. in Unknown on line 0"
because of byte-code optimizations results of coverage collection can be wrong, as the source beeing executed might no longer match the actual php script sources
closes sebastianbergmann/php-code-coverage#1022