Refactor algebraic circle fit routine#11
Open
samantha-ho wants to merge 1 commit intosebastianprobst:masterfrom
Open
Refactor algebraic circle fit routine#11samantha-ho wants to merge 1 commit intosebastianprobst:masterfrom
samantha-ho wants to merge 1 commit intosebastianprobst:masterfrom
Conversation
Owner
|
Thank you for your contribution. I have 2 questions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the core algebraic circle fit routine for improved usability and readability.
The core algebraic circle fit has been pulled into a separate, stand-alone module for easier reuse outside this set of tools.
Additionally, the previously hardcoded equations for the coefficients of the characteristic polynomial of (M - xB) have been replaced by first converting to the related eigenvalue problem (MB_inverse - xI)B whose determinant is det(MB_inverse-xI)*det(B). This allows us to use the Faddeev-LeVerrier Algorithm to calculate the coefficients of the characteristic polynomial without needing to hardcode them, and improves the readability of the code.
Finally, the automatic code-formatting tool
blackwas run on circlefit.py, causing numerous formatting changes.