feat(datatables): add Column::visible() for conditional column visibility#113
Merged
sebastienheyd merged 1 commit intomasterfrom Feb 14, 2026
Merged
Conversation
…lity Allow users to dynamically show/hide columns based on request parameters without triggering "column not found" errors. Columns should always be defined in columns() and use visible() to toggle visibility conditionally. Also guard against columns without data in Datatable::make() to prevent errors with special columns. Closes #92 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Column::visible(bool)method to dynamically toggle column visibility based on request parameters (e.g.,->visible(request()->post('showMine', false)))Column::hidden()to delegate tovisible(false)datainDatatable::make()to prevent errors with special columnsCloses #92
Usage
Instead of conditionally adding/removing columns (which causes "column not found" errors), always define all columns and use
visible():Test plan
Column::visible(true)does not addvisibleto attributesColumn::visible(false)setsvisible: falseColumn::hidden()still works as beforeColumn::hidden()->visible(true)removes the hidden state