Fix IReadOnlyDictionary being treated as array-like instead of dictionary#2287
Merged
lahma merged 2 commits intosebastienros:mainfrom Feb 15, 2026
Merged
Fix IReadOnlyDictionary being treated as array-like instead of dictionary#2287lahma merged 2 commits intosebastienros:mainfrom
lahma merged 2 commits intosebastienros:mainfrom
Conversation
…nary Types implementing IReadOnlyDictionary<string, TValue> but not IDictionary<string, TValue> were incorrectly classified as array-like because IReadOnlyDictionary inherits IReadOnlyCollection which set the isCollection flag, while the dictionary detection only checked for IDictionary<,>. Added IReadOnlyDictionary<,> detection in TypeDescriptor.AnalyzeType so these types are properly recognized as dictionaries and serialized as objects by JSON.stringify instead of arrays. Fixes sebastienros#2284 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types implementing
IReadOnlyDictionary<string, TValue>but notIDictionary<string, TValue>were incorrectly classified as array-like becauseIReadOnlyDictionaryinheritsIReadOnlyCollectionwhich set theisCollectionflag, while the dictionary detection only checked forIDictionary<,>.Added
IReadOnlyDictionary<,>detection inTypeDescriptor.AnalyzeTypeso these types are properly recognized as dictionaries and serialized as objects byJSON.stringifyinstead of arrays.Fixes #2284