Open
Conversation
Owner
|
Test failing on npgsql |
Updated ISqlBuilder and SqlBuilder Join methods to include a new onTableIsAlias parameter. Modified InnerJoin, LeftJoin, and RightJoin extension methods to pass this parameter. Adjusted DefaultQuery InnerJoin call to set onTableIsAlias to true for _documentTable. Added a new test ShouldReturnFirstOrDefaultJoinedIndexes in CoreTests and made minor formatting changes.
| { | ||
| // Don't prefix if alias is used | ||
| if (alias != onTable) | ||
| if (alias != onTable && !onTableIsAlias) |
Owner
There was a problem hiding this comment.
Seeing this, I believe we don't need a new field and just to set the alias argument instead such that it knows that onTable is an alias.
Contributor
|
@MichaelPetrinolis could you please fix the build and react to Seb comment? I think there are several PRs stuck for a while |
Author
|
Hello @hishamco, I think that you wanted to mention me ;) I will try this week to fix the npgsql test failure. |
Contributor
|
Sorry I just messed up with another PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can select from the Index and supports All/Any
closes #479