Skip to content

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Sep 17, 2023

  • switch PyPy to 3.10

Breaking issues:

  • there's a bug (https://foss.heptapod.net/pypy/pypy/-/issues/4003) in PyPy that breaks our tests when a backslash is used to break, so we need it to be fixed before merging this.
  • brotli is currently having issues with the latest PyPy version: https://github.com/google/brotli/issues/1072 (bypassed in Tests are failing under PyPy3 #4115 by pinning the version). I however don't expect this to be fixed any time soon, considering their track record.

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.88%. Comparing base (4296eee) to head (592f28b).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4126   +/-   ##
=======================================
  Coverage   80.88%   80.88%           
=======================================
  Files         368      368           
  Lines       90335    90335           
=======================================
  Hits        73069    73069           
  Misses      17266    17266           

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

guedou
guedou previously approved these changes Sep 18, 2023
polybassa
polybassa previously approved these changes Oct 10, 2023
@STMhack

This comment has been minimized.

@gpotter2
Copy link
Member Author

Ugh. I don't want to have and debug this. whyyyyy pypy

@gpotter2
Copy link
Member Author

The macos failure is funny though.

###(063)=[failed] Test signal fuzzing offset 1

>>> test_offset = 100
>>> 
>>> class testFrame3(SignalPacket):
...     fields_desc = [
...         BEUnsignedSignalField("muxSig7", default=0, start=2, size=8, scaling=1, offset=test_offset),
...     ]
... 
>>> pkt = testFrame3()
>>> pkt = fuzz(pkt)
>>> 
>>> li = [pkt.muxSig7._fix() for x in range(100000)]
>>> 
>>> assert abs(round(sum(li) / len(li)) - 128 - test_offset) < 2
Traceback (most recent call last):
  File "<input>", line 2, in <module>
AssertionError

As I understand is that was very, very unlikely :p

@gpotter2
Copy link
Member Author

Oh hey ! Tests pass !

@gpotter2 gpotter2 merged commit c776b9f into secdev:master Oct 16, 2025
25 checks passed
@gpotter2 gpotter2 deleted the pypy310 branch October 16, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants