Skip to content

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Nov 25, 2024

  • minor smb improvements (properly reset the session when a bad password is given)
  • minor kerb improvements (add kkdcp)

@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.62%. Comparing base (45de3db) to head (9ee7426).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/kerberos.py 60.00% 4 Missing ⚠️
scapy/layers/smbclient.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4597      +/-   ##
==========================================
- Coverage   81.62%   81.62%   -0.01%     
==========================================
  Files         358      358              
  Lines       85654    85665      +11     
==========================================
+ Hits        69916    69923       +7     
- Misses      15738    15742       +4     
Files with missing lines Coverage Δ
scapy/layers/smbclient.py 74.25% <0.00%> (-0.10%) ⬇️
scapy/layers/kerberos.py 66.23% <60.00%> (-0.05%) ⬇️

... and 5 files with indirect coverage changes

---- 🚨 Try these New Features:

@gpotter2 gpotter2 merged commit 62e335d into secdev:master Nov 25, 2024
23 checks passed
@gpotter2 gpotter2 deleted the smb-kkdcp branch November 25, 2024 14:49
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant