Skip to content

Conversation

@satveerbrar
Copy link
Contributor

Added max_count=123 to the FieldListField for the registerVal field to override the global conf.max_list_count =100

fixes #4573

@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (c424205) to head (7817309).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4633      +/-   ##
==========================================
- Coverage   81.61%   81.59%   -0.03%     
==========================================
  Files         359      341      -18     
  Lines       86052    85781     -271     
==========================================
- Hits        70234    69991     -243     
+ Misses      15818    15790      -28     
Files with missing lines Coverage Δ
scapy/contrib/modbus.py 90.98% <ø> (ø)

... and 273 files with indirect coverage changes

Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@gpotter2 gpotter2 merged commit a444240 into secdev:master Feb 3, 2025
23 of 24 checks passed
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modbus packet not being parsed correctly in 2.6.0

2 participants