LL_VERSION_IND Subversion field should be little-endian #4662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4662 +/- ##
==========================================
- Coverage 81.55% 78.56% -3.00%
==========================================
Files 359 334 -25
Lines 86557 81357 -5200
==========================================
- Hits 70592 63918 -6674
- Misses 15965 17439 +1474
|
guedou
approved these changes
Feb 9, 2025
Member
|
Thanks for the PR! |
antoniovazquezblanco
approved these changes
Feb 20, 2025
gpotter2
approved these changes
Mar 5, 2025
Member
gpotter2
left a comment
gpotter2
left a comment
There was a problem hiding this comment.
Thanks for the PR & sorry for the delay.
It's nicer to have unit tests when fixing bugs, although for the size of this one it's alright.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Subversion field of LL_VERSION_IND is little-endian (like most other fields). However currently it's being parsed as big-endian. This change fixes the definition to be little-endian.