Add missing type in AsyncSniffer #4665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gpotter2
commented
Feb 13, 2025
gpotter2
commented
- Add missing type in AsyncSniffer
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4665 +/- ##
==========================================
- Coverage 81.55% 81.55% -0.01%
==========================================
Files 359 359
Lines 86557 86558 +1
==========================================
Hits 70592 70592
- Misses 15965 15966 +1
|
louis-6wind
added a commit
to louis-6wind/scapy
that referenced
this pull request
Jun 30, 2025
When trying to stop a sniffer that was not already started,
Scapy_Exception("Unsupported (offline or unsupported socket)") is no
more raised and join() is waiting indefinitely.
Restore the previous stop_cb behavior.
Fixes: 6689da4 ("Add missing type in AsyncSniffer (secdev#4665)")
Signed-off-by: Louis Scalbert <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.