Skip to content

Fix AsyncSniffer Attribute Error #4800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpotter2 merged 2 commits into from
Jul 30, 2025
Merged

Fix AsyncSniffer Attribute Error #4800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbc895c
Fix AsyncSniffer Attribute Error
louis-6wind Jul 21, 2025
19e5e86
Forward error + test
gpotter2 Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scapy/sendrecv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1401,6 +1401,11 @@ def stop(self, join=True):
"""Stops AsyncSniffer if not in async mode"""
if self.running:
self.stop_cb()
if not hasattr(self, "continue_sniff"):
# Never started -> is there an exception?
if self.exception is not None:
raise self.exception
return None
if self.continue_sniff:
raise Scapy_Exception(
"Unsupported (offline or unsupported socket)"
Expand Down
9 changes: 9 additions & 0 deletions test/regression.uts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1787,6 +1787,15 @@ try:
except ValueError:
assert True

try:
sniffer = AsyncSniffer(iface="this_interface_does_not_exists")
sniffer.start()
sniffer.thread.join()
sniffer.stop()
assert False, "Should have errored by now"
except ValueError:
assert True

= Sending a TCP syn 'forever' at layer 2 and layer 3
~ netaccess needs_root IP
def _test():
Expand Down
Loading