Skip to content

Conversation

@gpotter2
Copy link
Member

  • implement offset computation for SECURITY_DESCRIPTOR
  • test it

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.01%. Comparing base (be3e1ae) to head (305efc2).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/modules/ldaphero.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4809   +/-   ##
=======================================
  Coverage   81.01%   81.01%           
=======================================
  Files         365      365           
  Lines       89069    89075    +6     
=======================================
+ Hits        72155    72165   +10     
+ Misses      16914    16910    -4     
Files with missing lines Coverage Δ
scapy/layers/smb2.py 88.49% <100.00%> (+0.38%) ⬆️
scapy/modules/ldaphero.py 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 merged commit 58526ec into secdev:master Jul 30, 2025
24 checks passed
@gpotter2 gpotter2 deleted the secdesc branch July 30, 2025 22:48
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant