-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Tun: add support for Darwin utun interface #4816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes secdev#4049 Darwin creates tunnel interfaces differently than BSD, breaking the existing handling which is based on generic BSD `tun`. This commit adds a new tunnel layer specific to the Darwin utun interface.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4816 +/- ##
==========================================
- Coverage 80.88% 80.88% -0.01%
==========================================
Files 368 368
Lines 90211 90231 +20
==========================================
+ Hits 72969 72983 +14
- Misses 17242 17248 +6
🚀 New features to boost your workflow:
|
|
This PR has been open for a month and I haven't been seeing any new feedback. Is there some kind of additional test that should be added to facilitate things? This is my first time opening PR to this project so I'm not familiar with the maintainers expectations beyond what the docs already mentioned. |
|
Hi. Sorry for the delay. I'm basically alone to review dozens of PRs, and I often don't have that much time to allocate to it ^^ It looks fine. Thanks for your work. |
Fixes #4049
Darwin creates tunnel interfaces differently than BSD, breaking the existing handling which is based on generic BSD
tun. This commit adds a new tunnel layer specific to the Darwin utun interface.This PR picks up the work after the draft PR #4100 got abandoned 2 years ago.
Checklist:
cd test && ./run_testsortox)TunTapInterfaceattempts to handle tunnels in Darwin by following the BSD code path. However, this fails for multiple reasons, including the initial rejection of the interface name beginning with "utun" rather than "tun". This PR adds special-case handling for Darwin.fixes #4049