Skip to content

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Oct 4, 2025

This PR:

  • adds a nbns_request to query Netbios names

@codecov
Copy link

codecov bot commented Oct 4, 2025

Codecov Report

❌ Patch coverage is 21.95122% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.76%. Comparing base (c776b9f) to head (9c31f3e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/netbios.py 15.78% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4853      +/-   ##
==========================================
- Coverage   80.88%   80.76%   -0.12%     
==========================================
  Files         368      368              
  Lines       90339    90378      +39     
==========================================
- Hits        73069    72994      -75     
- Misses      17270    17384     +114     
Files with missing lines Coverage Δ
scapy/layers/dns.py 83.61% <ø> (ø)
scapy/route.py 91.85% <100.00%> (ø)
scapy/sendrecv.py 85.53% <100.00%> (-0.94%) ⬇️
scapy/layers/netbios.py 76.13% <15.78%> (-16.62%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 marked this pull request as ready for review October 16, 2025 19:09
@gpotter2 gpotter2 merged commit 29d7360 into secdev:master Oct 16, 2025
24 of 25 checks passed
@gpotter2 gpotter2 deleted the nbns-request branch October 16, 2025 19:19
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant