Fix CEF filling up %TEMP% on Windows with temp files and never being cleared#24
Open
Hecklezz wants to merge 1 commit intosecondlife:masterfrom
Open
Fix CEF filling up %TEMP% on Windows with temp files and never being cleared#24Hecklezz wants to merge 1 commit intosecondlife:masterfrom
Hecklezz wants to merge 1 commit intosecondlife:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, overtime as dullahan is running in the background, it will accumulate a large number of "chrome_BITS" and some "chrome_url_fetcher" temp files in the OS's %TEMP% folder. These never get cleaned up and end up creating hundreds or even thousands of these over the span of a few days.
They are mostly harmless and generally very small in size or just empty folders, but still not ideal just letting %TEMP% fill up with these and no cleanup mechanic.
This PR simply just sets the entire TEMP (and TMP just in case) path on Windows for the given dullahan instance, to point to the cef_cache/pid/cache folder. That way, when the viewer runs and does LLAppViewer::purgeCefStaleCaches, these temp folders will get cleaned up in the process.
(Other platforms may be effected, but from what Beq observed, and me looking on a VM, Linux does not seem to be effected, unsure about macOS however)
Screenshot showing what was happening to %TEMP% after a short period of time having Second Life viewer running-
Screenshot showing after this PR has been applied-