Add new functions bit32.s32 and bit32.smul#69
Conversation
HaroldCindy
left a comment
HaroldCindy
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just a couple nits.
| }, | ||
| "@sl-slua/global/bit32.s32": { | ||
| "documentation": "Mod this number from float64 range to signed int32 range and truncate to integer. Makes integer arithmetic compatable with LSL.", | ||
| "learn_more_link": "https://create.roblox.com/docs/reference/engine/libraries/bit32#s32" |
There was a problem hiding this comment.
There isn't a docs link as of yet ;)
Might need a generator update for things that don't actually have upstream docs?
There was a problem hiding this comment.
I'd have to mark them. and it's only temporary that there aren't docs, so I'd rather not worry about it. I'd be doing work that needs reverting
There was a problem hiding this comment.
Makes sense, we can come up with a better notation when there's somewhere else to point people.
slua_definitions.yaml
Outdated
| must-use: true | ||
| - name: smul | ||
| comment: Multiplies two signed 32-bit integers. Returns the result as a signed 32-bit integer, wrapping as necessary. | ||
| Avoids precision loss ascociated with float64 multiplication. Compatable with LSL integer multiplication. |
There was a problem hiding this comment.
s/Compatable/Compatible/
slua_definitions.yaml
Outdated
| returnType: number | ||
| must-use: true | ||
| - name: s32 | ||
| comment: Mod this number from float64 range to signed int32 range and truncate to integer. |
There was a problem hiding this comment.
"Mod" is ambiguous in this context
|
Looks like the files just need regenerating |
done |
2 participants
No description provided.