Always try to match a master file by @file meta#61
Merged
Rider-Linden merged 1 commit intosecondlife:developfrom Mar 4, 2026
Merged
Always try to match a master file by @file meta#61Rider-Linden merged 1 commit intosecondlife:developfrom
@file meta#61Rider-Linden merged 1 commit intosecondlife:developfrom
Conversation
Contributor
|
Yeh when I switched that config check, I hadn't considered users adding the flag themselves manually. I can't really see this change causing any issues. |
Rider-Linden
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always try matching a master file via the
@filecomment, regardless of any setting:@filecomment is not auto-generatedMotivation
These two PR's were developed and merged independently, at about the same time:
However, these two PR's have a functional conflict: #55 is not very useful without the setting that #50 removed:
@fileto modifying the script on sending to the viewer@filematchingThis PR resolves the functional conflict:
An example of a situation I got today:
I added the third
@filecomment manually, some weeks ago. The other two got added by the plugin today, after 2 viewer -> plugin -> viewer round trips