Add new LastModified option to HttpRequest handling #4563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HttpOpRequest::prepareRequest()
|
Thanks, @fmartian this seems reasonable. Do you plan on using LastModified for a specific purpose? |
Well, I was adding it to my local branch for adding some OpenSim functionality and thought it would be a handy addition to upstream and as it is a rather lightweight patch, I didn't think it would be any burden on the project, even if the official viewer is not currently using that options. Not sure if the LL servers support If-Modified-Since:, but if they do it could be beneficial to add this option on the client side eventually for various HTTP(s) requests. |
bennettgoble
approved these changes
Aug 18, 2025
marchcat
approved these changes
Aug 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a LastModified: option to the HttpOptions class and handle it properly in HttpOpRequest::prepareRequest()
In LLGridManager in getGridLabel() and getGridId() the grid_name could be empty if an invalid name in grid was passed in