Skip to content

Add scenario elements#29

Open
argenos wants to merge 4 commits intomainfrom
add-scenarios
Open

Add scenario elements#29
argenos wants to merge 4 commits intomainfrom
add-scenarios

Conversation

@argenos
Copy link
Member

@argenos argenos commented Feb 9, 2026

No description provided.

@argenos argenos marked this pull request as ready for review February 10, 2026 15:23
@argenos argenos requested a review from minhnh February 10, 2026 15:23
@minhnh
Copy link
Member

minhnh commented Feb 22, 2026

Why don't you make a separate one just for open scenarios? It's relatively easy to migrate later you're done fleshing out the details. I don't think making the "generic" version is required or a priority now right? This is also why I have kept my concepts in a separate namespace.

A few comments:

  • Why would there be both Agent and Robot?
  • ConfigFile is probably not part of the "agent" metamodel or? "Configuration" is a concept going beyond any file system, so you probably would run into issue when configs are not passed by "files" but other means, e.g. ROS topics. I will likely have a HasConfiguration concept that can be used with agents, objects, workspaces as well.
  • I'd move Mesh to simulation maybe? And I would also be more specific with which "mesh" you are talking about. I think you mean Polygon Mesh?
  • Do you want to enforce every scenario with a run number? I think a more scalable identification scheme would be UUID or?
  • I think Artefact as a concept is not very useful, as every model you create is an "artefact." Is there something specific that you have in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants