Skip to content

change circle to github action#835

Merged
YanZhuangz merged 2 commits intosecretflow:mainfrom
yujun4464:main
Jul 21, 2025
Merged

change circle to github action#835
YanZhuangz merged 2 commits intosecretflow:mainfrom
yujun4464:main

Conversation

@yujun4464
Copy link
Contributor

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @yujun4464, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on migrating the documentation publishing workflow by removing its configuration from CircleCI, as indicated by the removal of the docs_publish job and workflow entry in .circleci/config.yml. This change is in line with the stated intent to transition CI/CD processes to GitHub Actions. Additionally, the PR includes minor, non-functional formatting corrections within the project's documentation files.

Highlights

  • CI/CD Migration: The docs_publish job and its associated workflow trigger have been entirely removed from the .circleci/config.yml file. This change indicates a migration of the documentation publishing process away from CircleCI, aligning with the pull request's title to transition to GitHub Actions.
  • Documentation Formatting: Minor formatting adjustments were made in the Chinese documentation file docs/deployment/kuscia_config_cn.md and its corresponding translation source file docs/locales/en/LC_MESSAGES/deployment/kuscia_config_cn.po. Specifically, an extraneous space was removed for improved readability and consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to migrate the documentation publishing from CircleCI to GitHub Actions. It successfully removes the old CircleCI job configuration. However, the corresponding GitHub Actions workflow that should replace it appears to be missing from this PR. I've left a critical comment highlighting this, as it will break the documentation deployment pipeline. The other changes are minor and correct typographical issues in documentation files.

Copy link
Collaborator

@YanZhuangz YanZhuangz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YanZhuangz YanZhuangz merged commit 8499678 into secretflow:main Jul 21, 2025
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants