Skip to content

add unittest coverage html#852

Merged
yushiqie merged 6 commits intosecretflow:mainfrom
yujun4464:main
Aug 27, 2025
Merged

add unittest coverage html#852
yushiqie merged 6 commits intosecretflow:mainfrom
yujun4464:main

Conversation

@yujun4464
Copy link
Contributor

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @yujun4464, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances our continuous integration pipeline by introducing automated unit test coverage reporting. The primary goal is to provide immediate visibility into test coverage for every build, including a detailed HTML report and a diff report that focuses on changes relative to the main branch, thereby promoting higher code quality and test discipline.

Highlights

  • CI/CD Enhancement: I've integrated new steps into the CircleCI configuration to automatically generate and store unit test coverage reports in HTML format, making it easier to track code quality.
  • Coverage Reporting: The pipeline now produces both a full coverage.html report and a coverage_diff.html report, which specifically highlights coverage changes relative to the origin/main branch and enforces a 50% minimum coverage for new or changed code.
  • Tooling Integration: To achieve comprehensive coverage analysis, I've added the installation of diff-cover, gocov, and gocov-xml tools directly within the CI environment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new step to the CircleCI configuration to generate and store code coverage reports, including a diff coverage report. The review suggests pinning dependency versions and using python3-pip for improved reproducibility and clarity.

Copy link
Collaborator

@yushiqie yushiqie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yushiqie yushiqie merged commit 41a03eb into secretflow:main Aug 27, 2025
9 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants