Open
Conversation
Signed-off-by: MikkiYang <hecy7@asiainfo.com>
wenyuanhust
reviewed
Jul 23, 2025
Collaborator
wenyuanhust
left a comment
wenyuanhust
left a comment
There was a problem hiding this comment.
看上去OK，请问修改后，有打包实际运行测试吗
Contributor
Author
我们内部有allinone部署的环境，每次更新（无论是secretPad、kuscia、 secretflow、 spu）都会重做镜像或对应库进行测试，并运行如下工作流。 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphBuilder中的node2inputs定义为局部变量使用即可，方法执行结束立即回收，满足最小可见性原则的同时无需GC时随对象实例回收，减少对象长期持有的内存
其余修改中通过Spring注入的不可变对象增加final修饰，防止后续维护时意外修改字段引用，保护对象完整性