Conversation
✅ Deploy Preview for sats-connect ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There's some part of the build process that only looks at the node_modules of the root directory. As such, the build was failing when vite-plugin-node-polyfill was not added to the top level package.json despite not being used there. The nested project structure trips up the polyfills.
|
teebszet
approved these changes
Jul 24, 2025
ShaunLWM
approved these changes
Jul 24, 2025
Contributor
ShaunLWM
left a comment
ShaunLWM
left a comment
There was a problem hiding this comment.
Screen.Recording.2025-07-24.at.16.57.06.mov
Contributor
Author
|
There's some part of the build process that only looks at the node_modules of the root directory. As such, the build was failing when vite-plugin-node-polyfill was not added to the top level package.json despite not being used there. The nested project structure trips up the polyfills. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: secretkeylabs/sats-connect-core#86