Skip to content

Conversation

@edwin1729
Copy link
Contributor

@edwin1729 edwin1729 commented Jul 31, 2025

Those programs with no open review threads or assumes in PR 11 are copied over here to be merged

The following programs were dropped
007
037
072
077

see original commits and review at #11

coauthored by @WeetHet

@edwin1729 edwin1729 force-pushed the reviewed branch 2 times, most recently from d41de7b to fcf22b8 Compare July 31, 2025 16:20
@edwin1729
Copy link
Contributor Author

There seems to be a problem with the CI. The required version of rustc isn't being installed in the vm

@parno
Copy link
Contributor

parno commented Jul 31, 2025

Thanks, it will be great to get these added in. I updated the CI script on main, so if you merge that in, hopefully that will fix the CI on your branch.

Looking back at #11, it seems like 037 might be complete. Were there still pending issues with it?

@edwin1729
Copy link
Contributor Author

Looking back at #11, it seems like 037 might be complete. Were there still pending issues with it?

There were over 5 programs which I believe used to compile but broke with an error along the lines of while loop requires a decreases clause. I have fixed all of those except 037. 037 gives further errors on fixing the while error which I don't quite understand so I dropped it.

@edwin1729
Copy link
Contributor Author

also ci is now failing due to merged programs being broken by backwards incompatible changes to verus

@parno
Copy link
Contributor

parno commented Aug 4, 2025

also ci is now failing due to merged programs being broken by backwards incompatible changes to verus

Hmm, indeed. I'll try to fix that up early next week and then get this merged.

@parno
Copy link
Contributor

parno commented Aug 11, 2025

Okay, I fixed up the existing files, so CI passes on main. I manually checked your modified files, and they pass, so I'll merge this in.

@parno parno merged commit aa630c4 into secure-foundations:main Aug 11, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants