Add ASN.1 primitives to vest-examples
#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: fix `length` impl for `base128` and `var_int`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ASN.1 combinators from Verdict to
vest-examples.This is based on @y1ca1's previous work on migrating ASN.1 combinators from Verdict (where he did most of the proof fixes). I just made some modifications on it to work with the latest Vest version and added it to
vest-examples.I did also attempt to migrate the X.509 combinators to the latest Vest. However, due to a number of tricky issues with the trait differences, coupled with the complicated macros in the original X.509 implementations, it's still in progress.