Develop palani

[palaniappan1]

No description provided.

[Copilot]

Pull request overview

This PR expands the Jimple→FAIR conversion and analysis pipeline with (1) push-based optimization hint registration for fold-heavy methods, (2) a generalized constant-normalization pass for Jimple bodies, and (3) configurable + more efficient call-graph leveling (SCC + leveling strategies), with additional benchmarking/reporting to compare phases.

Changes:

• Add an OptimizationRegistry that records per-method fold statistics at fold-creation time (via FoldHelper) to surface alias-analysis candidates.
• Replace the old field-store-only normalization with a broader ConstantNormalizer that extracts constants from multiple expression positions into fresh locals.
• Extend call-graph topological sorting with selectable SCC/leveling strategies and add method-level benchmark diff reporting.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
TODO.MD	Updates generator TODO items and marks array handling as done.
src/test/kotlin/OptimizationRegistryTest.kt	Adds unit tests for the new optimization registry behavior.
src/test/kotlin/converter/ConstantNormalizerTest.kt	Adds tests validating constant extraction and name-collision handling.
src/test/kotlin/benchmark/FAIRGeneratorBenchmarkTest.kt	Adds per-method metrics + phase-to-phase diff report, plus CG-opt summarized/pruned annotations.
src/main/kotlin/semantics/FAIRSemanticsContext.kt	Makes context policy non-null (default NoContextFactory) and adds resolveContextId.
src/main/kotlin/semantics/call/MonotoneCallSemantics.kt	Removes !! on context policy and routes call context via resolveContextId.
src/main/kotlin/semantics/call/IFDSCallSemantics.kt	Adjusts call emission for void callees and updates argument-mapping calls to pass context.
src/main/kotlin/semantics/call/CallHelper.kt	Uses resolveContextId when building call statements; updates API to accept context.
src/main/kotlin/optimizer/OptimizationRegistry.kt	Implements concurrent fold-stat tracking and reporting.
src/main/kotlin/optimizer/OptimizationHint.kt	Defines the alias-analysis candidate hint with fold-count breakdown.
src/main/kotlin/optimizer/MethodOptimizationProfile.kt	Adds a method-level profile wrapper + readable toString.
src/main/kotlin/helper/FoldHelper.kt	Push-registers folds into OptimizationRegistry during conversion.
src/main/kotlin/helper/CallGraphTopologicalSorter.kt	Adds Tarjan SCC, alternative leveling strategy, and new strategy enums/params.
src/main/kotlin/converter/interceptor/FieldStoreNormalizer.kt	Removes the old field-store-only normalizer.
src/main/kotlin/converter/interceptor/ConstantNormalizer.kt	Adds the new multi-position constant extraction transformer.
src/main/kotlin/converter/FAIRTranslationSuite.kt	Switches normalization to ConstantNormalizer and standardizes context policy selection.
src/main/kotlin/converter/FAIRMethodConverter.kt	Uses blocksSorted and makes context init unconditional-call to the policy.
src/main/kotlin/converter/ConverterConfig.kt	Adds config knobs for SCC algorithm and leveling strategy.
fair.core/src/main/kotlin/model/type/ClassType.kt	Fixes equals/hashCode to include packageName (aligning with toString).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The final assertion is ineffective: "$cTmp0".repeat(2) produces the single string "$cTmp0$cTmp0", so this does not detect duplicate locals named "$cTmp0". If the intent is to ensure the original $cTmp0 local is not duplicated, assert on the count of that name (or on distinct()/containsExactlyOnce).

Suggested change

	assertThat(result.locals.map { it.name }).contains("\$cTmp1")
	assertThat(result.locals.map { it.name }).doesNotContain("\$cTmp0".repeat(2)) // still only one $cTmp0
	val localNames = result.locals.map { it.name }
	assertThat(localNames).contains("\$cTmp1")
	assertThat(localNames.count { it == "\$cTmp0" }).isEqualTo(1) // still only one $cTmp0

[Copilot]

currentContext is only set when contextPolicy.emitInit(...) returns a non-empty list. With NoContextFactory (used for ContextStrategy.NONE), emitInit returns an empty list, leaving currentContext null; MonotoneCallSemantics later dereferences context.currentContext!! and will throw. Consider initializing currentContext to the root ContextId regardless of whether context statements are emitted (or making MonotoneCallSemantics tolerate the no-context policy).

[Copilot]

KDoc says sccAlgorithm defaults to SccAlgorithm.KOSARAJU, but computeLevels actually defaults to SccAlgorithm.TARJAN. Update the documentation (or the default) so callers understand which algorithm is used by default.

[Copilot]

sccAlgorithm and levelingStrategy are added to ConverterConfig, but there is no usage in the production code path (the conversion still calls CallGraphTopologicalSorter.computeLevels(toConvert, calleesMap) without passing these). Either wire these options into FAIRWholeProgramConverter when computing levels or remove them to avoid a misleading/unused configuration surface.

[Copilot]

perMethodMetrics stores bodyText = m.fairBody.toString() for every non-opaque method and every phase. For large programs this can significantly increase memory usage and distort the benchmark (or even OOM). Consider making bodyText lazy/optional (only computed for methods that differ) or guarding it behind a flag so the default benchmark run only collects numeric metrics.