Skip to content

feat: add promote-to-candidate ReleasePlans manifests#250

Merged
osmman merged 1 commit intomainfrom
cac-release-plans
Oct 15, 2025
Merged

feat: add promote-to-candidate ReleasePlans manifests#250
osmman merged 1 commit intomainfrom
cac-release-plans

Conversation

@osmman
Copy link
Contributor

@osmman osmman commented Oct 15, 2025

Summary by Sourcery

Add new promote-to-candidate release plan manifests and remove outdated version overlays

New Features:

  • Add base/promote-to-candidate Kustomize manifest aggregating component, fbc, operator, pco-fbc, and policy-controller-operator overlays
  • Introduce operator-v1-3 overlay for the promote-to-candidate release plan

Enhancements:

  • Include promote-to-candidate directory in the base release-plan kustomization
  • Update operator overlay kustomization and patch to use operator-v1-3 nameSuffix and application

Chores:

  • Remove legacy promote-to-candidate overlays for fbc-v1-1 and operator-v1-0/v1-1

Signed-off-by: Tomas Turek <tturek@redhat.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 15, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR reorganizes the promote-to-candidate release plans by introducing a centralized base kustomization, migrating the operator overlay to version v1-3, and cleaning up obsolete fbc and operator overlays under the legacy releasePlans directory.

Flow diagram for migration of operator overlay to v1-3

flowchart TD
    A["operator-v1-0 overlay"] -->|removed| B["(no longer present)"]
    C["operator-v1-1 overlay"] -->|removed| B
    D["operator-v1-2 overlay"] -->|retained| E["operator-v1-2 overlay"]
    F["operator-v1-3 overlay"] -->|added| G["operator-v1-3 overlay (new)"]
Loading

Flow diagram for removal of obsolete fbc overlays

flowchart TD
    A["fbc-v1-1 overlays (v4-15, v4-16, v4-17, v4-18)"] -->|removed| B["(no longer present)"]
Loading

File-Level Changes

Change Details Files
Create centralized promote-to-candidate base kustomization
  • Added promote-to-candidate directory to base release-plan kustomization resources
  • Created new kustomization manifest listing all component, fbc, operator, pco-fbc, and policy-controller overlays under promote-to-candidate
konflux-configs/base/release-plan/kustomization.yaml
konflux-configs/base/release-plan/promote-to-candidate/kustomization.yaml
Migrate and version-bump operator overlay to v1-3
  • Updated top-level operator overlays to drop v1-0/v1-1 and include operator-v1-3
  • Moved and renamed overlay directory to operator-v1-3 under promote-to-candidate
  • Adjusted nameSuffix and spec.application fields from operator-v1-0 to operator-v1-3
konflux-configs/releasePlans/promoteToCandidateRPs/operator/overlays/kustomization.yaml
konflux-configs/base/release-plan/promote-to-candidate/operator/overlays/operator-v1-3/kustomization.yaml
konflux-configs/base/release-plan/promote-to-candidate/operator/overlays/operator-v1-3/patch.yaml
Remove obsolete fbc-v1-1 and operator-v1-1 release plan overlays
  • Deleted the entire fbc-v1-1 directory including its base plan and all versioned overlays
  • Removed operator-v1-1 kustomization and its patch under releasePlans
  • Deleted the policy-controller-operator base kustomization in the legacy directory
konflux-configs/releasePlans/promoteToCandidateRPs/fbc-v1-1/**
konflux-configs/releasePlans/promoteToCandidateRPs/operator/overlays/operator-v1-1/kustomization.yaml
konflux-configs/releasePlans/promoteToCandidateRPs/operator/overlays/operator-v1-1/patch.yaml
konflux-configs/releasePlans/promoteToCandidateRPs/policy-controller-operator/base/kustomization.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

Configuration Diff

26 document(s) impacted:

+ 26 added
- 0 removed
! 0 modified
Diff
@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-cli
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-cli
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: cli
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: component
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-ctlog
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-ctlog
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: certificate-transparency-go
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: component
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-fbc-v4-15
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-fbc-v4-15
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: fbc-v4-15
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: fbc
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-fbc-v4-16
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-fbc-v4-16
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: fbc-v4-16
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: fbc
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-fbc-v4-17
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-fbc-v4-17
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: fbc-v4-17
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: fbc
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-fbc-v4-18
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-fbc-v4-18
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: fbc-v4-18
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: fbc
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-fbc-v4-19
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-fbc-v4-19
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: fbc-v4-19
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: fbc
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-fulcio
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-fulcio
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: fulcio
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: component
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-operator
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-operator
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: operator
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: operator
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-operator-v1-2
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-operator-v1-2
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: operator-v1-2
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: operator
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-operator-v1-3
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-operator-v1-3
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: operator-v1-3
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: operator
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-pco-fbc-v4-15
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-pco-fbc-v4-15
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: pco-fbc-v4-15
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: fbc
+       - name: file-name
+         value: policy-controller-operator-fbc.json
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-pco-fbc-v4-16
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-pco-fbc-v4-16
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: pco-fbc-v4-16
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: fbc
+       - name: file-name
+         value: policy-controller-operator-fbc.json
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-pco-fbc-v4-17
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-pco-fbc-v4-17
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: pco-fbc-v4-17
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: fbc
+       - name: file-name
+         value: policy-controller-operator-fbc.json
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
+           value: pipelines/promote-to-candidate.yaml
+         resolver: git
+       serviceAccountName: rhtas-build-bot

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-pco-fbc-v4-18
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ReleasePlan
+   metadata:
+     name: promote-to-candidate-pco-fbc-v4-18
+     namespace: rhtas-tenant
+     labels:
+       release.appstudio.openshift.io/auto-release: "true"
+       release.appstudio.openshift.io/standing-attribution: "true"
+   spec:
+     application: pco-fbc-v4-18
+     tenantPipeline:
+       params:
+       - name: git-url
+         value: "https://github.com/securesign/releases"
+       - name: code-freeze
+         value: "false"
+       - name: type
+         value: fbc
+       - name: file-name
+         value: policy-controller-operator-fbc.json
+       pipelineRef:
+         params:
+         - name: url
+           value: "https://github.com/securesign/pipelines"
+         - name: revision
+           value: main
+         - name: pathInRepo
... (diff truncated, showing first 500 lines)

📦 Artifacts: base-output.yaml, head-output.yaml, dyff-output.txt

@osmman osmman requested a review from JasonPowr October 15, 2025 11:46
@osmman osmman merged commit 92c7dd5 into main Oct 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants