Skip to content

feat: add timestamp-authority application#264

Merged
osmman merged 1 commit intomainfrom
cac-timestamp-authority
Oct 22, 2025
Merged

feat: add timestamp-authority application#264
osmman merged 1 commit intomainfrom
cac-timestamp-authority

Conversation

@osmman
Copy link
Contributor

@osmman osmman commented Oct 21, 2025

Summary by Sourcery

Add timestamp-authority application to konflux-configs with its Component, ImageRepository, and Application resources, and include it in the base kustomization

New Features:

  • Add ImageRepository for timestamp-authority with public visibility and SBOM webhook notifications
  • Add Component resource for timestamp-authority referencing its GitHub repo and custom build pipeline
  • Add Application resource for timestamp-authority with display name
  • Include timestamp-authority in the base application kustomization

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 21, 2025

Reviewer's Guide

Introduces the new "timestamp-authority" application by updating the root kustomization to include it and adding its base directory with Kustomization, Application, Component, and ImageRepository manifests to configure source, build pipeline annotations, image registry, and webhook notifications.

Entity relationship diagram for timestamp-authority manifests

erDiagram
  APPLICATION ||--o| COMPONENT : contains
  COMPONENT ||--o| IMAGEREPOSITORY : builds
  IMAGEREPOSITORY ||--o| WEBHOOK : triggers

  APPLICATION {
    string name
    string displayName
  }
  COMPONENT {
    string componentName
    string gitUrl
    string revision
    string dockerfileUrl
    string pipelineAnnotation
  }
  IMAGEREPOSITORY {
    string imageName
    string visibility
  }
  WEBHOOK {
    string url
    string event
    string method
    string title
  }
Loading

File-Level Changes

Change Details Files
Register timestamp-authority in the root application kustomization
  • Added 'timestamp-authority/base' to the resources list
konflux-configs/base/application/kustomization.yaml
Add base setup for the timestamp-authority application
  • Created kustomization.yaml to aggregate application, component, and image repository resources
  • Added application.yaml with Application kind, name, and displayName spec
konflux-configs/base/application/timestamp-authority/base/kustomization.yaml
konflux-configs/base/application/timestamp-authority/base/application.yaml
Define Component for timestamp-authority
  • Added Component manifest with pipeline annotations
  • Configured git source URL, revision, and Dockerfile path
konflux-configs/base/application/timestamp-authority/base/component.yaml
Configure ImageRepository with public image and SBOM webhook
  • Specified the public image name and repository visibility
  • Added webhook notification for SBOM repo_push events
konflux-configs/base/application/timestamp-authority/base/imagerepository.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The Application CR in application.yaml is missing the spec.components field to link the timestamp-authority component, so it won’t actually manage the component.
  • The ImageRepository name is quite verbose—consider using a shorter, more consistent naming convention (for example, "timestamp-authority-imagerepo").
  • To ensure reproducible builds, pin the Component git revision to a tag or commit instead of using the mutable “main” branch.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The Application CR in application.yaml is missing the spec.components field to link the timestamp-authority component, so it won’t actually manage the component.
- The ImageRepository name is quite verbose—consider using a shorter, more consistent naming convention (for example, "timestamp-authority-imagerepo").
- To ensure reproducible builds, pin the Component git revision to a tag or commit instead of using the mutable “main” branch.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Configuration Diff

5 document(s) impacted:

+ 4 added
- 0 removed
! 1 modified
Diff
@@ metadata.name @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-timestamp-authority
! ± value change
- promote-to-candidate-tsa
+ promote-to-candidate-timestamp-authority

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/Application/rhtas-tenant/timestamp-authority
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: Application
+   metadata:
+     name: timestamp-authority
+     namespace: rhtas-tenant
+   spec:
+     displayName: "timestamp-authority (main)"

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/Component/rhtas-tenant/timestamp-authority
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: Component
+   metadata:
+     name: timestamp-authority
+     namespace: rhtas-tenant
+     annotations:
+       build.appstudio.openshift.io/pipeline: "{\"name\":\"docker-build-oci-ta\",\"bundle\":\"latest\"}"
+       git-provider: github
+       git-provider-url: "https://github.com"
+   spec:
+     source:
+       git:
+         url: "https://github.com/securesign/timestamp-authority.git"
+         dockerfileUrl: Dockerfile.tsa.rh
+         revision: main
+     application: timestamp-authority
+     componentName: timestamp-authority

@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ImageRepository/rhtas-tenant/imagerepository-for-timestamp-authority-timestamp-authority
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1alpha1
+   kind: ImageRepository
+   metadata:
+     name: imagerepository-for-timestamp-authority-timestamp-authority
+     namespace: rhtas-tenant
+     labels:
+       appstudio.redhat.com/application: timestamp-authority
+       appstudio.redhat.com/component: timestamp-authority
+   spec:
+     image:
+       name: rhtas-tenant/timestamp-authority/timestamp-authority
+       visibility: public
+     notifications:
+     - config:
+         url: "https://bombino.api.redhat.com/v1/sbom/quay/push"
+       event: repo_push
+       method: webhook
+       title: SBOM-event-to-Bombino

@@ (root level) @@
# appstudio.redhat.com/v1beta2/IntegrationTestScenario/rhtas-tenant/timestamp-authority-enterprise-contract
! + one document added:
+   ---
+   apiVersion: appstudio.redhat.com/v1beta2
+   kind: IntegrationTestScenario
+   metadata:
+     name: timestamp-authority-enterprise-contract
+     namespace: rhtas-tenant
+     annotations:
+       test.appstudio.openshift.io/kind: enterprise-contract
+   spec:
+     application: timestamp-authority
+     resolverRef:
+       params:
+       - name: url
+         value: "https://github.com/konflux-ci/build-definitions"
+       - name: revision
+         value: main
+       - name: pathInRepo
+         value: pipelines/enterprise-contract.yaml
+       resolver: git
+       resourceKind: pipeline

📦 Artifacts: base-output.yaml, head-output.yaml, dyff-output.txt

Signed-off-by: Tomas Turek <tturek@redhat.com>
@osmman osmman force-pushed the cac-timestamp-authority branch from f15d060 to 03fa14e Compare October 21, 2025 11:23
@osmman osmman merged commit 975d120 into main Oct 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants