Merged
Conversation
Reviewer's GuideIntroduces the new "timestamp-authority" application by updating the root kustomization to include it and adding its base directory with Kustomization, Application, Component, and ImageRepository manifests to configure source, build pipeline annotations, image registry, and webhook notifications. Entity relationship diagram for timestamp-authority manifestserDiagram
APPLICATION ||--o| COMPONENT : contains
COMPONENT ||--o| IMAGEREPOSITORY : builds
IMAGEREPOSITORY ||--o| WEBHOOK : triggers
APPLICATION {
string name
string displayName
}
COMPONENT {
string componentName
string gitUrl
string revision
string dockerfileUrl
string pipelineAnnotation
}
IMAGEREPOSITORY {
string imageName
string visibility
}
WEBHOOK {
string url
string event
string method
string title
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The Application CR in application.yaml is missing the spec.components field to link the timestamp-authority component, so it won’t actually manage the component.
- The ImageRepository name is quite verbose—consider using a shorter, more consistent naming convention (for example, "timestamp-authority-imagerepo").
- To ensure reproducible builds, pin the Component git revision to a tag or commit instead of using the mutable “main” branch.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The Application CR in application.yaml is missing the spec.components field to link the timestamp-authority component, so it won’t actually manage the component.
- The ImageRepository name is quite verbose—consider using a shorter, more consistent naming convention (for example, "timestamp-authority-imagerepo").
- To ensure reproducible builds, pin the Component git revision to a tag or commit instead of using the mutable “main” branch.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Configuration Diff5 document(s) impacted: + 4 added
- 0 removed
! 1 modifiedDiff@@ metadata.name @@
# appstudio.redhat.com/v1alpha1/ReleasePlan/rhtas-tenant/promote-to-candidate-timestamp-authority
! ± value change
- promote-to-candidate-tsa
+ promote-to-candidate-timestamp-authority
@@ (root level) @@
# appstudio.redhat.com/v1alpha1/Application/rhtas-tenant/timestamp-authority
! + one document added:
+ ---
+ apiVersion: appstudio.redhat.com/v1alpha1
+ kind: Application
+ metadata:
+ name: timestamp-authority
+ namespace: rhtas-tenant
+ spec:
+ displayName: "timestamp-authority (main)"
@@ (root level) @@
# appstudio.redhat.com/v1alpha1/Component/rhtas-tenant/timestamp-authority
! + one document added:
+ ---
+ apiVersion: appstudio.redhat.com/v1alpha1
+ kind: Component
+ metadata:
+ name: timestamp-authority
+ namespace: rhtas-tenant
+ annotations:
+ build.appstudio.openshift.io/pipeline: "{\"name\":\"docker-build-oci-ta\",\"bundle\":\"latest\"}"
+ git-provider: github
+ git-provider-url: "https://github.com"
+ spec:
+ source:
+ git:
+ url: "https://github.com/securesign/timestamp-authority.git"
+ dockerfileUrl: Dockerfile.tsa.rh
+ revision: main
+ application: timestamp-authority
+ componentName: timestamp-authority
@@ (root level) @@
# appstudio.redhat.com/v1alpha1/ImageRepository/rhtas-tenant/imagerepository-for-timestamp-authority-timestamp-authority
! + one document added:
+ ---
+ apiVersion: appstudio.redhat.com/v1alpha1
+ kind: ImageRepository
+ metadata:
+ name: imagerepository-for-timestamp-authority-timestamp-authority
+ namespace: rhtas-tenant
+ labels:
+ appstudio.redhat.com/application: timestamp-authority
+ appstudio.redhat.com/component: timestamp-authority
+ spec:
+ image:
+ name: rhtas-tenant/timestamp-authority/timestamp-authority
+ visibility: public
+ notifications:
+ - config:
+ url: "https://bombino.api.redhat.com/v1/sbom/quay/push"
+ event: repo_push
+ method: webhook
+ title: SBOM-event-to-Bombino
@@ (root level) @@
# appstudio.redhat.com/v1beta2/IntegrationTestScenario/rhtas-tenant/timestamp-authority-enterprise-contract
! + one document added:
+ ---
+ apiVersion: appstudio.redhat.com/v1beta2
+ kind: IntegrationTestScenario
+ metadata:
+ name: timestamp-authority-enterprise-contract
+ namespace: rhtas-tenant
+ annotations:
+ test.appstudio.openshift.io/kind: enterprise-contract
+ spec:
+ application: timestamp-authority
+ resolverRef:
+ params:
+ - name: url
+ value: "https://github.com/konflux-ci/build-definitions"
+ - name: revision
+ value: main
+ - name: pathInRepo
+ value: pipelines/enterprise-contract.yaml
+ resolver: git
+ resourceKind: pipeline📦 Artifacts: base-output.yaml, head-output.yaml, dyff-output.txt |
Signed-off-by: Tomas Turek <tturek@redhat.com>
f15d060 to
03fa14e
Compare
fghanmi
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add timestamp-authority application to konflux-configs with its Component, ImageRepository, and Application resources, and include it in the base kustomization
New Features: