Skip to content

Conversation

@rainer-exxcellent
Copy link
Contributor

fixes issue #102

file created by JavascriptExporter.createHtml are now deleted
files created from AdvisoryService.exportAdvisory are already deleted in the calling service in every case

write log information about the deleted files

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Test Results

303 tests   303 ✅  36s ⏱️
 23 suites    0 💤
 23 files      0 ❌

Results for commit 55e33c0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Overall Project 90% -0.2% 🍏
Files changed 62.96% 🍏

File Coverage
AdvisoryController.java 97.47% -1.52%
JavascriptExporter.java 94.63% -3.31% 🍏

@rainer-exxcellent rainer-exxcellent force-pushed the fix/#102-remove_temp_files branch from 9adde9f to 55e33c0 Compare January 28, 2025 09:06
@github-actions
Copy link
Contributor

Overall Project 90% -0.2% 🍏
Files changed 62.96% 🍏

File Coverage
AdvisoryController.java 97.47% -1.52%
JavascriptExporter.java 94.63% -3.31% 🍏

Copy link
Contributor

@mfd2007 mfd2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfd2007 mfd2007 merged commit 530c592 into main Jan 28, 2025
3 checks passed
@mfd2007 mfd2007 deleted the fix/#102-remove_temp_files branch June 3, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants